Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Displaysets not editable when Json-kind Interface is used #3565

Open
miriam-groeneveld opened this issue Sep 26, 2024 · 1 comment · May be fixed by #3465
Open

Displaysets not editable when Json-kind Interface is used #3565

miriam-groeneveld opened this issue Sep 26, 2024 · 1 comment · May be fixed by #3465

Comments

@miriam-groeneveld
Copy link
Contributor

Describe the bug
A clear and concise description of what the bug is.

To Reproduce
Steps to reproduce the behavior:

  1. Go to a reader study that has a display set with a Json CIV.
  2. Edit a display set that doesn't have a value for the Json CI
  3. Save the display set
  4. Now the displayset shows an added Json CI, but the value is null, causing a server error when trying to edit the display set.
  5. See video and sentry error: https://grand-challenge.sentry.io/issues/5910158018/?project=303639&query=%21logger%3Acsp%20is%3Aunresolved&referrer=issue-stream&statsPeriod=24h&stream_index=0

Expected behavior
Display set should remain editable

Screenshots
https://github.com/user-attachments/assets/34d4a6eb-5abe-4d59-b66b-89aabf67a34f

Desktop (please complete the following information):

  • OS: [e.g. iOS]
  • Browser [e.g. chrome, safari]
  • Version [e.g. 22]

Smartphone (please complete the following information):

  • Device: [e.g. iPhone6]
  • OS: [e.g. iOS8.1]
  • Browser [e.g. stock browser, safari]
  • Version [e.g. 22]

Additional context
Add any other context about the problem here.

@amickan
Copy link
Contributor

amickan commented Sep 26, 2024

This is a general issue with the InterfaceFormField and how we handle/pass initial data to it. This is fixed by the refactoring done in #3465

@amickan amickan linked a pull request Sep 26, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants