Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance improvement: Do we need to render building twice? #1335

Open
matkoniecz opened this issue Feb 12, 2024 · 0 comments
Open

Performance improvement: Do we need to render building twice? #1335

matkoniecz opened this issue Feb 12, 2024 · 0 comments
Assignees

Comments

@matkoniecz
Copy link
Contributor

Currently we render both base buildings (colour affected by dark/light style) and the same buildings are again rendered in style of given layer.

Maybe it would be more efficient to render them once?

https://colouring.london/tiles/base_night/18/130974/87151.png
https://colouring.london/tiles/date_year/18/130974/87151.png

87151
87151a

How this can be done:

(1) have the same colour for building with no data both in dark and light style - may be not acceptable

(2) have separate dark and light style for each map style - additional work

Benefit of changes should be increased performance.
This can be tested to check what is the benefit and is it worth extra complexity.

@polly64 polly64 changed the title Do we need to render building twice? Performance improvement: Do we need to render building twice? Mar 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants