Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

datamapper support #11

Open
nashby opened this issue Sep 4, 2011 · 5 comments
Open

datamapper support #11

nashby opened this issue Sep 4, 2011 · 5 comments
Labels

Comments

@nashby
Copy link
Member

nashby commented Sep 4, 2011

Did somebody try edit datamapper's model with arnold? We have datamapper branch if you didn't know :)
I think it's ready to be merged and I need some response!

@razielgn
Copy link
Contributor

razielgn commented Sep 4, 2011

Looks good to go to me, although I think it needs a manual merge because of the recent commits.

@jeffkreeftmeijer
Copy link

Looks good for as far as I can see. I'd like to get rid of the DataMapper specific stuff, but I haven't used DataMapper too often, so I can't really comment on how reasonable that is. Thoughts? :)

@razielgn
Copy link
Contributor

razielgn commented Sep 4, 2011

I suggested him to go with the module mixin for datamapper since the methods have just different names. I don't think we can avoid that. Also, arnold.rb is growing bigger and bigger, I think we should begin to split it.

@nashby
Copy link
Member Author

nashby commented Sep 4, 2011

Yeah, totally agree with @razielgn about splitting.

@jeffkreeftmeijer
Copy link

Alright, I think we can merge this in. Let's talk about splitting in a new issue. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants