Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: added comments, added people can comment chapters, some improvements #80

Merged
merged 4 commits into from
Feb 9, 2024

Conversation

siinghd
Copy link
Collaborator

@siinghd siinghd commented Feb 7, 2024

Build: Working on local

Features:
Comments: users can comment under the video/notion
Replies: Users can reply to a comment (Allowed only to depth 1 like youtube)
Upvotes/downvote: user can upvote or downvote the comment

Comment as chapter: user can comment chapters following the current format:

intro:
00:03 - Introduction to the topic
00:15 - Explaining the basics
00:30 - Deep dive into details
00:45 - 00:50 - Summary and conclusion

This is fully working and the comment is inserted as type INTRO and with flag approved to false.

Note*: In this PR admin part is not included but i was thinking to add a accept button or dropdown option where the admin can accept it. Second option would be to copy the comment id and on admin part make a input with comment id,adminpassword and approve button.

On accepted the comment will be transformed to reflect the segments array and saved, the function to do it is already present thank to CHATGPT :)

Also user can click the timestamp in the comments and the video timestamp will be set to that.


Missing:
Admin part to accept the chapter comment
Admin can delete any comment
Users update/delete their comment

This is what i remember, ill update this if get to remember something else.

Improvemnts:
Many ui related improvement can be done
Maybe use react query for infinite scroll and remove current pagination

preview

2024-02-08-00-19-52_qW58um8W.mp4

Copy link

vercel bot commented Feb 7, 2024

@siinghd is attempting to deploy a commit to the My Team Team on Vercel.

A member of the Team first needs to authorize it.

@siinghd siinghd changed the title Feature: added comments, started people can comment chapters, some improvements Feature: added comments, added people can comment chapters, some improvements Feb 7, 2024
@siinghd
Copy link
Collaborator Author

siinghd commented Feb 8, 2024

@hkirat can you look at this? would like to merge and do the admin part/some improvements

@hkirat
Copy link
Contributor

hkirat commented Feb 8, 2024

Wow, beautiful
Will check this out soon. Thankyou @siinghd

@siinghd
Copy link
Collaborator Author

siinghd commented Feb 9, 2024

Now admin can also approve the intro comments

preview:

screen-recording-2024-02-09-at-113953-pm_pOzDYbbd.mp4

@hkirat
Copy link
Contributor

hkirat commented Feb 9, 2024

Beautiful

@hkirat hkirat merged commit 162e7f3 into code100x:main Feb 9, 2024
1 of 2 checks passed
@hkirat
Copy link
Contributor

hkirat commented Feb 9, 2024

/bounty $400

@hkirat
Copy link
Contributor

hkirat commented Feb 9, 2024

Can u try deploying this to a local vercel @siinghd ?
Seeing this in the build pipeline on vercel
Screenshot 2024-02-10 at 4 28 33 AM

@siinghd
Copy link
Collaborator Author

siinghd commented Feb 9, 2024

@hkirat Was about to ping you, saw the deploy failed... let me do it now :)

Thanks for the bounty veere <3

@hkirat
Copy link
Contributor

hkirat commented Feb 9, 2024

Something is up with migrations
Screenshot 2024-02-10 at 5 12 34 AM

Unsure if it broke here or in a different PR
But migrate is not working on a fresh DB

@siinghd
Copy link
Collaborator Author

siinghd commented Feb 9, 2024

@hkirat let me look at it

@hkirat
Copy link
Contributor

hkirat commented Feb 9, 2024

Just need to migrate the DB I think I can figure this out @siinghd

@siinghd
Copy link
Collaborator Author

siinghd commented Feb 10, 2024

@hkirat any update on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants