New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: ci is not working properly #350

Closed

ezhil56x opened this issue Apr 9, 2024 · 0 comments · Fixed by #351

Labels

bug

Contributor

ezhil56x commented Apr 9, 2024

Describe the bug

In Feature: added comments, added people can comment chapters, some improvements #80
npm run lint:check and npm run format:check in ci have been changed to npm run lint:fix and npm run format:fix
Even when the format:fix and lint:fix runs in ci, we can't update it in the PR without a github personal token
This check passes always resulting in unformatted code merged into the main

Expected behavior
Reverting back it to npm run lint:check and npm run format:check will break the ci if the code in the PR is not formatted

The text was updated successfully, but these errors were encountered:

ezhil56x added the bug label

ezhil56x mentioned this issue

ci: improve ci #351

Merged

2 tasks

hkirat closed this as completed in #351

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment