Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: Store ips of the user in the db along with token, make sure token is valid for that ip #1156

Open
hkirat opened this issue Sep 7, 2024 · 5 comments
Labels
bug Something isn't working

Comments

@hkirat
Copy link
Contributor

hkirat commented Sep 7, 2024

If someone steals my jwt, they should not be able to access my dashboard
we should check if the ip is the same as the one they logged in with

@hkirat hkirat added the bug Something isn't working label Sep 7, 2024
@ItsFlash10
Copy link
Contributor

ItsFlash10 commented Sep 7, 2024

on it, trying

@farjad-akhan
Copy link

On it! #trying

@MeerUzairWasHere
Copy link
Contributor

MeerUzairWasHere commented Sep 7, 2024

@hkirat We have to add model for IP, where we save all ips or just one more column in user table?
and we can stop him to login if ip are not same?
but we have to remove the ip from db when user logout from that device?

@NawinKumarSharma
Copy link

@hkirat , do we need to save ipAddress in session or userschema?

@devsargam
Copy link
Collaborator

@hkirat do we want this? really

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants