Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracking: make sure optd does not crash for TPC-H queries #68

Open
22 of 29 tasks
Gun9niR opened this issue Feb 15, 2024 · 3 comments
Open
22 of 29 tasks

Tracking: make sure optd does not crash for TPC-H queries #68

Gun9niR opened this issue Feb 15, 2024 · 3 comments

Comments

@Gun9niR
Copy link
Contributor

Gun9niR commented Feb 15, 2024

Missing features

  • Subquery: Q2, Q3, Q4, Q11, Q16, Q17, Q20, Q21, Q22
    • Correlated subquery is not supported in DF physical optimizer. DF's logical optimizer eliminates OuterReferenceColumn by moving the column to the outer query. Since we do not know how to access columns of the outer query, I think we should enable DF's logical optimizer when dealing with subqueries.
    • With DF's logical optimizer enabled, we get Error during planning: table 'datafusion.public.xxxx' not found error. When using explain_with_logical in the planner test, make sure to execute the DDLs with execute_with_logical!
  • InListExpr: Q12, Q16, Q19 feat: support InListExpr #77
  • IntervalMonthDayNano: Q1, Q10, Q14(feat: support IntervalMonthDayNano DF type #78)
  • Multiple (non-equal) predicates for one join: Q11, Q13, Q22
  • ColumnRefPropertyBulder
    • LogOp: Q16
  • Left anti and left semi join: Q4, Q16, Q18, Q20, Q21, Q22
@jurplel
Copy link
Member

jurplel commented Feb 15, 2024

We should test more TPC-H queries and make a list of what features we're missing.

@AveryQi115
Copy link
Contributor

It seems q1 is failed for card test:

Error: Arrow error: Not yet implemented: Unsupported Interval Expression with value "115 day (3) seconds"

Caused by:
Not yet implemented: Unsupported Interval Expression with value "115 day (3) seconds"

@Gun9niR
Copy link
Contributor Author

Gun9niR commented Mar 21, 2024

It seems q1 is failed for card test:

Error: Arrow error: Not yet implemented: Unsupported Interval Expression with value "115 day (3) seconds"

Caused by: Not yet implemented: Unsupported Interval Expression with value "115 day (3) seconds"

The error is thrown from SessionState::statement_to_plan, which means it's DF's problem, not optd's. We can modify the tpch template so it generates something DF supports.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants