From 1d05c8e1502b70efccd4f56ed064f9b6f844d1b5 Mon Sep 17 00:00:00 2001
From: Daniel Lamando <dan@danopia.net>
Date: Mon, 14 Aug 2023 22:59:20 +0200
Subject: [PATCH] Remove zlib pooling, destroy on close instead

We do not need this optimization since SPDY isn't really done at scale
anymore.
---
 lib/spdy-transport/protocol/spdy/zlib-pool.ts | 23 +++++--------------
 1 file changed, 6 insertions(+), 17 deletions(-)

diff --git a/lib/spdy-transport/protocol/spdy/zlib-pool.ts b/lib/spdy-transport/protocol/spdy/zlib-pool.ts
index 4bcdd01..2f537ce 100644
--- a/lib/spdy-transport/protocol/spdy/zlib-pool.ts
+++ b/lib/spdy-transport/protocol/spdy/zlib-pool.ts
@@ -31,14 +31,8 @@ export type CompressionPair = {
 
 export class CompressionPool {
   compression: boolean;
-  pool: { 2: CompressionPair[]; 3: CompressionPair[]; 3.1: CompressionPair[]; };
   constructor (compression: boolean) {
     this.compression = compression
-    this.pool = {
-      2: [],
-      3: [],
-      3.1: []
-    }
   }
 
   static create (compression: boolean) {
@@ -46,20 +40,15 @@ export class CompressionPool {
   }
 
   get (version: 2|3|3.1) {
-    if (this.pool[version].length > 0) {
-      return this.pool[version].pop()!
-    } else {
-      const id = version
-
-      return {
-        version: version,
-        compress: _createDeflate(id, this.compression),
-        decompress: _createInflate(id),
-      }
+    return {
+      version: version,
+      compress: _createDeflate(version, this.compression),
+      decompress: _createInflate(version),
     }
   }
 
   put (pair: CompressionPair) {
-    this.pool[pair.version].push(pair)
+    pair.compress.close();
+    pair.decompress.close();
   }
 }