Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SSM parameters should be optional #68

Open
arturtamborski opened this issue Sep 28, 2023 · 0 comments
Open

SSM parameters should be optional #68

arturtamborski opened this issue Sep 28, 2023 · 0 comments

Comments

@arturtamborski
Copy link

Describe the Feature

Hello!

Thank you for this (and other) modules! They are a breeze to use and help us a lot during development.

I would like to propose that SSM parameter creation should be optional. The reason is twofold:

  1. always-created SSM parameters is unexpected behavior when compared with rest of your modules (namely: rds, redis)
  2. We'd like to manage all SSM parameters in one place (with your ssm module btw), but this module forces us to either duplicate the parameters or split the configuration.

I'm happy to implement this feature if you agree to it and comment with a suggestion for the switch name.

Expected Behavior

SSM parameter creation should be hidden behind an optional flag. Probably set as a default to false?

Use Case

We would like to keep all parameters in one place and set them according to our needs, with values sourced from this module's outputs. That's technically still possible, but the module creates its own parameters, causing a bit of confusion and duplication.

Describe Ideal Solution

SSM parameter creation is hidden behind a flag.
If flag is set to false => no SSM parameter will be created automatically by the module.
If set to true => module works as it does now.

Alternatives Considered

No response

Additional Context

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant