Make Route Dispatching a Little Less Imperative

[gf3]

Allow routes to be dispatched from (and optionally defined to?) different collections. This'll make things like testing and optional routes easier to work with.

E.g.:

(secretary/dispatch! "/users/gf3")
;; To ↓ 
(secretary/dispatch! some-defed-routes "/users/gf3")

Thanks for the suggestion, @sgrove.

[sgrove]

Specifically, it would be great to do something like:

    (let [user-handler (fn [user-id]
                         (print "User looked up: " user-id))
          test-routes (-> {}
                          (secretary/assoc-route :v1-channel-link "/v1/channels/:channel-id" channel-handler)
                          (secretary/assoc-route :v1-user-link "/v1/users/:user-id" user-handler))]
      (secretary/dispatch! test-routes "/v1/users/10"))

And have everything self-contained/referentially transparent

[noprompt]

Definitely. This is along the lines of what we were discussing in #9. At work we've encountered some situations where this functionality would be nice.

Ideally, it'd be nice to have something along the lines of

(defroutes death-routes
  (route poison-path "/poison/:type" ...)
  (route stab-path "/stab/:with" ..))

which would essentially expand to the code @sgrove shared above in test-routes part. The spec for defroutes might be [name] [name opts] where name is the var name and opts would be for configuring render-route etc. route would also need to be macro and essentially just be reusing the some of the current defroute code.

[gf3]

Mmm—I like the sounds of that 👍

[noprompt]

Should we bump to 2.0.0 after this? Seems like it's major enough.

[gf3]

Yeah, sounds good.

[noprompt]

Question: Should we also implement context? See here.

[gf3]

Let's hold off for now. And do it later if we need it.

[edbond]

context is a good thing. Definetely should be implemented imo. 💊

[gf3]

I agree, but perhaps in a different PR.

[noprompt]

Alright, good idea.

[noprompt]

I've started work on this in a separate branch here. The current syntax looks like

(defroutes routes-name
  (ROUTE users-path "/users" [])
  (ROUTE user-path "/users/:id" [id])
  (ROUTE user-edit-path "/users/:id/edit" [id]))

This defines an instance of a new type secretary.core/Routes which delegates to several of the old functions for lookup, etc. The symbols defined by defroutes can also be included in other defroutes. context has not been implemented but I expect to get to it soon.

If anyone has questions or ideas let me know. 😄