Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to latest dropwizard metrics #133

Open
eranharel opened this issue Mar 13, 2018 · 10 comments
Open

Upgrade to latest dropwizard metrics #133

eranharel opened this issue Mar 13, 2018 · 10 comments

Comments

@eranharel
Copy link
Contributor

The latest dropwizard metrics (4.x.x) removed a lot of clutter, and is now Java 8 based and supports Java 9.
Now that the older (< 8) Java versions are EOL it makes sense to upgrade, and I'll be happy to contribute a patch if it's agreed.

@michaelklishin
Copy link
Collaborator

Please submit a PR.

@eranharel
Copy link
Contributor Author

eranharel commented Mar 14, 2018

I'm already on it @michaelklishin.
I require some input though:
I noticed this project contains some outdated components which were removed from dropwizard metrics, or are no longer maintained. For example the Rieman, influxdb and Ganglia reporters.
If you want to keep support for these components, it will probably require upgrading the target projects. This will require more time than I probably have, as it requires specific knowledge on these components and installations in order to properly test the change.

I guess the decision of whether to keep these components should be based on actual usage, and what you'd like to support.

It may be possible to only make a partial update - still don't know...

WDYT?

@michaelklishin
Copy link
Collaborator

Are there separate projects for those targets? I find it hard to believe that InfluxDB and Metrics have so few users in common.

I'd like to keep those but if it means maintaining 3 more projects that's probably unrealistic, so we should drop them. Our next release will be a 3.0, so we can do that.

@eranharel
Copy link
Contributor Author

I agree, dropwizard and InfluxDB are both popular projects. InfluxDB is now a part of a commercial product though, which may have reduced some of the users.
I'm still trying to find an alternative solution for the seemingly dead dependencies.
Will post my finding here next week.

@eranharel
Copy link
Contributor Author

I opened these issues:
iZettle/dropwizard-metrics-influxdb#84
riemann/riemann-java-client#87

Metrics-ganglia is gone. Couldn't find this project, or anything similar.

I'll wait to see how they respond, then decide how to proceed

@jakemcc
Copy link

jakemcc commented Jan 2, 2019

@eranharel Looks like those projects did upgrades. Any update on what you were working on?

@eranharel
Copy link
Contributor Author

@jakemcc I started upgrading it on my laptop back then when I opened this ticket. Can't find this work now, but it wasn't that difficult - mainly package renaming and such.

I'll find time to come back to this soon. It shouldn't take me long to do this once I start.

@otrosien
Copy link

otrosien commented Apr 8, 2019

ping.. shall someone take over?

@michaelklishin
Copy link
Collaborator

@otrosien feel free to submit a PR.

@atw-gr
Copy link
Contributor

atw-gr commented May 2, 2019

I think we're close on the InfluxDB and Riemann reporters supporting Java 9+ and using Riemann 4.x:

metrics-ganglia looks to be dropped for good: dropwizard/dropwizard#2239

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants