-
Notifications
You must be signed in to change notification settings - Fork 674
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Snap build/publish Github action #6805
Open
Nightmayr
wants to merge
17
commits into
clementine-player:master
Choose a base branch
from
Nightmayr-snaps:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
224311c
adding workflow to build snap
Nightmayr dc01932
adding workflow to build snap
Nightmayr f6167fe
Merge branch 'snap-workflow' of github.com:Nightmayr-snaps/Clementine…
Nightmayr dd9bb9e
uploading snap artifact and adding to release
Nightmayr 2f77ce6
specifying 64 bit build in job name
Nightmayr 11470e1
removing checkout in build_snap
Nightmayr d1edd16
adding checkout v1.2.0
Nightmayr 47b676c
Merge pull request #1 from Nightmayr-snaps/snap-workflow
Nightmayr 54da09f
adding check for master branch to publish
Nightmayr 071fa1a
added closing quote
Nightmayr 19af31d
Merge pull request #2 from Nightmayr-snaps/snap-workflow
Nightmayr fece58f
updating snapcraft.yaml
Nightmayr 80396ba
removed commenented config
Nightmayr 88a9aac
fixing KDE file picker
Nightmayr d7b551d
replacing with audio-playback as pulseaudio is deprecated
Nightmayr 00e554f
no need to clone clementine repo, adding snap to gitignore
Nightmayr 7cbdd37
setting correct snap version
Nightmayr File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -99,6 +99,7 @@ jobs: | |
| - build_focal_64 | ||
| - build_mac | ||
| - build_mingw | ||
| - build_snap | ||
| - build_source | ||
| - build_stretch_64 | ||
| steps: | ||
|
|
@@ -740,6 +741,24 @@ jobs: | |
| with: | ||
| name: release_focal_64 | ||
| path: bin/clementine_*.deb | ||
|
|
||
| build_snap: | ||
| name: Build Snap | ||
| runs-on: ubuntu-18.04 | ||
| steps: | ||
| - uses: actions/[email protected] | ||
| - uses: snapcore/action-build@v1 | ||
| id: snapcraft | ||
| - uses: snapcore/action-publish@v1 | ||
| if: github.ref == 'refs/heads/master' | ||
| with: | ||
| store_login: ${{ secrets.SNAP_STORE_LOGIN }} | ||
| snap: ${{ steps.snapcraft.outputs.snap }} | ||
| release: edge | ||
| - uses: actions/upload-artifact@v2 | ||
| with: | ||
| name: release_snap | ||
| path: ${{ steps.snapcraft.outputs.snap }} | ||
|
|
||
| build_mac: | ||
| name: Build Mac DMG | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -44,3 +44,4 @@ dist/windows/Python27.zip | |
| src/translations/translations.pot | ||
| *.DS_Store | ||
| .vscode | ||
| *.snap | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems counter to the attempt at wayland support above.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs to stay.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is needed for clementine to run as an XWayland app when in a wayland session. Without this environment variable, clementine looks like this in Wayland:
With the environment variable set in Wayland (running on XWayland) :
As you can see the XWayland app keeps the GTK theming and cursor theme.