Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename VersionedStore#redo to VersionedStore#rollforward #13

Open
jmstacey opened this issue May 21, 2017 · 1 comment
Open

Rename VersionedStore#redo to VersionedStore#rollforward #13

jmstacey opened this issue May 21, 2017 · 1 comment

Comments

@jmstacey
Copy link

Given "redo" is a control statement, would it make sense to rename VersionedStore#redo to VersionedStore#rollforward ? That way it's similar to "rollback". Or perhaps VersionedStore#rewind and VersionedStore#replay ?

Just an idea I'm tossing out there. I discovered grand_central recently and gave it a whirl and that caught me by surprise.

@jgaskins
Copy link
Member

I've thought about the naming divergence between the methods before, but never really put enough thought into it to come up with a better name scheme for it. 😄 I actually chose redo to align with the Rails db:migrate:redo Rake task (since the opposite direction is also rollback). I thought about going with undo / redo, but I'm not sure how I feel about it. Nobody else has really weighed in on it so I'm happy for any feedback you've got!

I'm glad you're trying out the gem, though! I find it a lot of fun to use and the immutable models force me to think about problems differently, rather than rushing in in my usual fashion. I usually use it to manage data structures in server-side persistent processes and client-side with Clearwater.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants