You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Given "redo" is a control statement, would it make sense to rename VersionedStore#redo to VersionedStore#rollforward ? That way it's similar to "rollback". Or perhaps VersionedStore#rewind and VersionedStore#replay ?
Just an idea I'm tossing out there. I discovered grand_central recently and gave it a whirl and that caught me by surprise.
The text was updated successfully, but these errors were encountered:
I've thought about the naming divergence between the methods before, but never really put enough thought into it to come up with a better name scheme for it. 😄 I actually chose redo to align with the Rails db:migrate:redo Rake task (since the opposite direction is also rollback). I thought about going with undo / redo, but I'm not sure how I feel about it. Nobody else has really weighed in on it so I'm happy for any feedback you've got!
I'm glad you're trying out the gem, though! I find it a lot of fun to use and the immutable models force me to think about problems differently, rather than rushing in in my usual fashion. I usually use it to manage data structures in server-side persistent processes and client-side with Clearwater.
Given "redo" is a control statement, would it make sense to rename
VersionedStore#redo
toVersionedStore#rollforward
? That way it's similar to "rollback". Or perhapsVersionedStore#rewind
andVersionedStore#replay
?Just an idea I'm tossing out there. I discovered grand_central recently and gave it a whirl and that caught me by surprise.
The text was updated successfully, but these errors were encountered: