Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

schematron (?) warnings when the centre list differs from the list of recommendations #179

Closed
bansp opened this issue Nov 16, 2022 · 3 comments
Assignees
Labels
sanity-checker stuff that should potentially be handled by the sanity checker SIS:centres centre-oriented part of the SIS SIS:enhancement SIS:schemas document grammars for parts of the SIS DB wontfix
Milestone

Comments

@bansp
Copy link
Member

bansp commented Nov 16, 2022

There is a bit of an overlap between the contents of centres.xml and the contents of data/recommendations/. It would be good to install a check (warning, not error) for when they differ.
OR it could be done in the sanity checker! (see #115 )

@bansp bansp added SIS:enhancement SIS:centres centre-oriented part of the SIS labels Nov 16, 2022
@bansp bansp added this to the SIS v. 2.6.0 milestone Mar 7, 2023
@bansp
Copy link
Member Author

bansp commented Mar 7, 2023

Adding this to a milestone, to make sure that we find it easily. Assigning to myself to check if I can sensibly catch it at the level of Schematron.

@bansp bansp added SIS:schemas document grammars for parts of the SIS DB sanity-checker stuff that should potentially be handled by the sanity checker labels Mar 21, 2023
@bansp
Copy link
Member Author

bansp commented Mar 21, 2023

Actually, whatever is done with Schematron or XML Schema may also easily get into the sanity checker -- not everything is going to be edited by hand, in a schema-aware editor, after all.

@bansp bansp modified the milestones: SIS v. 2.6.0, SIS v. 2.7.0 Aug 7, 2023
@bansp bansp self-assigned this Oct 24, 2023
@bansp
Copy link
Member Author

bansp commented Oct 26, 2023

I first self-assigned this and then re-read the last comment. Actually, in view of issue #247 , this one might even end up as a wontfix.

@bansp bansp added the wontfix label May 21, 2024
@bansp bansp closed this as not planned Won't fix, can't repro, duplicate, stale May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sanity-checker stuff that should potentially be handled by the sanity checker SIS:centres centre-oriented part of the SIS SIS:enhancement SIS:schemas document grammars for parts of the SIS DB wontfix
Projects
None yet
Development

No branches or pull requests

1 participant