Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docker support #49

Open
geekflyer opened this issue Jul 12, 2022 · 3 comments
Open

Add docker support #49

geekflyer opened this issue Jul 12, 2022 · 3 comments
Labels

Comments

@geekflyer
Copy link

I would like to build M1 compatible docker images on Cirrus-CI.

Since it's currently not part of the image, I tried setting up docker as part of the pipeline (this is my WIP branch: aptos-labs/aptos-core#1876) but it doesn't work as it's a bit tricky to install docker on Mac in a headless environment apparently.

Would be great if a base image with pre-installed docker was made available.

Thanks!

@fkorotkov
Copy link
Contributor

The problem here is that Docker needs nested virtualization which is not supported in Apple's Virtualization.Framework that Tart is using. Nether less Docker on M1 is using Virtualization.Framework itself and runs a Linux VM to build images so I don't think there will be a difference in building on M1, QEMU or native Arm.

But once Docker will be able to be executed from within a VM we'll add it into the images.

@timsutton
Copy link
Contributor

as it's a bit tricky to install docker on Mac in a headless environment

@geekflyer
It's been years since I've looked into doing this, but it had been an issue in the very beginning: docker/for-mac#717

Have you looked at this? https://docs.docker.com/desktop/install/mac-install/#install-from-the-command-line

@fkorotkov
Copy link
Contributor

BTW there is now Arm64 Docker Builder option that runs Linux.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants