[gha cache] delete on success only (#782)

Otherwise, GHA Runners can get 404 on a retry
cirruslabs · Sep 3, 2024 · 43413dd · 43413dd
1 parent fc80340
commit 43413dd
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/internal/agent/http_cache/ghacache/ghacache.go b/internal/agent/http_cache/ghacache/ghacache.go
@@ -239,7 +239,6 @@ func (cache *GHACache) commitUploadable(writer http.ResponseWriter, request *htt
 
 		return
 	}
-	defer cache.uploadables.Delete(id)
 
 	var jsonReq struct {
 		Size int64 `json:"size"`
@@ -284,6 +283,9 @@ func (cache *GHACache) commitUploadable(writer http.ResponseWriter, request *htt
 		return
 	}
 
+	// Delete uploadable only on success. GHA Runner can retry in case of a failure.
+	cache.uploadables.Delete(id)
+
 	writer.WriteHeader(http.StatusCreated)
 }