Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doesn't work with squashed commits #138

Open
sandersky opened this issue Mar 3, 2018 · 3 comments
Open

Doesn't work with squashed commits #138

sandersky opened this issue Mar 3, 2018 · 3 comments
Labels

Comments

@sandersky
Copy link
Contributor

Github has a merge and squash feature, which this project doesn't play well with. In lib/utils.js _getLastPr() makes the assumption that ALL merged pull requests commits will contain pull request # but for a squash and merge commit this doesn't hold true. See below for an example:

screen shot 2018-03-02 at 8 48 23 pm

In the above example pr-bumper will always skip over my squash and merge commits and thus it isn't using the correct pull request info for bumping.

@sandersky sandersky added the bug label Mar 3, 2018
@job13er
Copy link
Contributor

job13er commented Mar 4, 2018

@sandersky Do you have any suggestion of a way for pr-bumper to know what the last merge commit is in your situation?

@job13er
Copy link
Contributor

job13er commented Mar 4, 2018

My initial gut response is we should just add a warning to the README.md that if you want to use pr-bumper you can't enable the merge and squash feature, unless there's some way for pr-bumper to detect what PR the merge build is associated with. I don't think just querying the server for the most recent merged PR is a good idea as there could be multiple merged in quick succession.

@notmessenger
Copy link
Contributor

I have opened #144 to add such documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants