Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consistent treatment of frequency reporters #19

Open
wiederm opened this issue Jan 17, 2024 · 0 comments
Open

Consistent treatment of frequency reporters #19

wiederm opened this issue Jan 17, 2024 · 0 comments

Comments

@wiederm
Copy link
Member

wiederm commented Jan 17, 2024

Currently, we save the parameter that controls the frequency reporters are called in the Sampler class.
We pass it in its __init__ method --- should we move this to the run method where we also set the number of sampling steps?

Also, we are currently saving coordinate sets for debugging in the sampler, should we move this to the reporter (this would only require to not write the buffer to disk but keep it in memory).

Originally posted by @chrisiacovella in #18 (comment)

@wiederm wiederm changed the title Consistent treatment of frequency reporters are called a Consistent treatment of frequency reporters Jan 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant