Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address deprecation of Imagick::radialBlurImage #61

Open
JoelAlphonso opened this issue Sep 8, 2022 · 0 comments
Open

Address deprecation of Imagick::radialBlurImage #61

JoelAlphonso opened this issue Sep 8, 2022 · 0 comments
Assignees
Labels
invalid This doesn't seem right

Comments

@JoelAlphonso
Copy link
Contributor

JoelAlphonso commented Sep 8, 2022

Originally posted by @mcaskill in #55 (comment)


Add note in this method's block comment and the README about the deprecation of Imagick::radialBlurImage and replacement with Imagick::rotationalBlurImage.

We should ensure this change is surfaced in this pull request's summary and the repository's CHANGELOG.

This commit is more than just a fix, it's potentially a breaking change since it requires a specific version of software/extension.

We should rename radial to rotational as well and add a radial alias with a deprecation notice. Otherwise, open an issue or draft pull request to address this change later along with ImageMagick equivalent.

This may be an issue in case servers or local environments with an out-of-date Imagick extension.

FYI @mducharme

@JoelAlphonso JoelAlphonso added the invalid This doesn't seem right label Sep 8, 2022
@JoelAlphonso JoelAlphonso changed the title Add note in this method's block comment and the README about the deprecation of [Imagick::radialBlurImage](https://www.php.net/manual/en/imagick.radialblurimage.php) and replacement with [Imagick::rotationalBlurImage](https://www.php.net/manual/en/imagick.rotationalblurimage.php). Address Imagick::radialBlurImage deprecation Sep 8, 2022
@mcaskill mcaskill changed the title Address Imagick::radialBlurImage deprecation Address deprecation of Imagick::radialBlurImage Sep 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid This doesn't seem right
Projects
None yet
Development

No branches or pull requests

3 participants