Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provide language selection as URL parameter #154

Open
Bananeweizen opened this issue Sep 6, 2017 · 7 comments
Open

provide language selection as URL parameter #154

Bananeweizen opened this issue Sep 6, 2017 · 7 comments
Assignees

Comments

@Bananeweizen
Copy link
Member

We should have the possibility to provide the wanted language for the FAQ via URL parameter. If that were available, we could invoke the FAQ from inside cgeo using the language of the cgeo app. That way a German user would immediately land on the German version of the FAQ.

@SammysHP
Copy link
Member

SammysHP commented Sep 6, 2017

If he has set up his browser / system language correctly it should be opened in the user locale by default. On the other hand this is easy to implement.

@SammysHP SammysHP self-assigned this Sep 6, 2017
@niklashigi
Copy link
Contributor

niklashigi commented Sep 7, 2017

@SammysHP I've already implemented this locally.

/faq?lang=de

I'll make a pull request together with my fix for #153.

@Bananeweizen
Copy link
Member Author

At least on my phone just going from the app (with German localization) to the FAQ does not lead to German text. I'm not thinking I have anything set to English on my real device.

@SammysHP
Copy link
Member

SammysHP commented Sep 7, 2017

Works fine here.

@Lineflyer
Copy link
Member

What link within the app are you trying @Bananeweizen @SammysHP ?

@SammysHP
Copy link
Member

SammysHP commented Sep 7, 2017

@Lineflyer In "about c:geo" faq.cgeo.org.

@Bananeweizen
Copy link
Member Author

Bananeweizen commented Sep 8, 2017

Ah, you are right. I get the German version, but the first paragraph of the FAQ itself is not translated, only the questions underneath. That made me think I had the English version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants