Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polkadot vault transaction error #1608

Closed
annamehr opened this issue Oct 2, 2023 · 1 comment
Closed

Polkadot vault transaction error #1608

annamehr opened this issue Oct 2, 2023 · 1 comment
Assignees
Labels
bug Something isn't working prio 72h Should be done in the next 72 hours

Comments

@annamehr
Copy link
Contributor

annamehr commented Oct 2, 2023

High priority bug

Bug report

  • Unable to sign txns with Polkadot vault
  • I tried using both talisman and Polkadot.js extension
  • Web3Foundation and Jay have tried

Steps to Reproduce

  • Connect Polkadot Vault with Talisman
  • Connect Talisman wallet and Centrifuge app
  • Start onboarding and sign transaction

unnamed-1
image
image (1)
image (2)

@annamehr annamehr added bug Something isn't working prio 72h Should be done in the next 72 hours labels Oct 2, 2023
@jpangelle
Copy link
Contributor

jpangelle commented Oct 2, 2023

After digging in, I don't think this is an issue on the app side.

If I just try to sign a "raw" transaction directly from the Polkadot portal using Talisman with a Polkadot Vault account, I get the same error:

Transaction

image

Result

image

For polkadot.js, same thing:

Transaction and Result

image

I found this Github issue which supposedly fixed the issue. This issue was closed in October 2022 but Polkadot.js extension has not been updated since June 2022 so the fix is not reflected in the extension so that explains the issue with Polkadot.js.

For Talisman, I found this statement in an open issue:

Currently Talisman inherits its signing logic directly from the polkadot.js extension. So, if polkadot.js can sign something, we should be able to too, and if we can't but they can, we would consider it a bug.

So ultimately, I think the the polkadot.js folks need to release a new version/extension and this will resolve both the polkadot.js extension and Talisman issue.

It appears that there is an open to do for this in the polkadot.js extension repo with activity as recently as August 29 so they appear to be working on it. Until this is done, I don't think there is anything we can do on our end. Once they release the new version, then we would may need to update a few packages like @polkadot/extension-dapp and @subwallet/wallet-connect.

@jpangelle jpangelle reopened this Oct 2, 2023
@annamehr annamehr closed this as completed Oct 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working prio 72h Should be done in the next 72 hours
Projects
None yet
Development

No branches or pull requests

2 participants