Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refocusing big block tests on 8MB block sizes and simplifying maintenance #3865

Open
2 of 3 tasks
staheri14 opened this issue Sep 11, 2024 · 3 comments · May be fixed by #3866
Open
2 of 3 tasks

Refocusing big block tests on 8MB block sizes and simplifying maintenance #3865

staheri14 opened this issue Sep 11, 2024 · 3 comments · May be fixed by #3866
Assignees
Labels
testing items that are strictly related to adding or extending test coverage

Comments

@staheri14
Copy link
Contributor

staheri14 commented Sep 11, 2024

Problem

Initially, for the big block test, the plan was to run e2e benchmark tests for block sizes of 8, 32, and 64MB. However, the focus later shifted to 8MB blocks. While the current constants in celestia-app are compatible with 8MB blocks, modifying those constants was necessary to produce larger blocks, which led to this PR, based on which the e2e big block tests are run.
Since the current focus is on 8MB blocks, maintaining that branch is no longer necessary, so

Acceptance Criteria

@staheri14 staheri14 self-assigned this Sep 11, 2024
@staheri14 staheri14 added testing items that are strictly related to adding or extending test coverage and removed needs:triage labels Sep 11, 2024
@evan-forbes
Copy link
Member

atm, knuu isn't suitable for reliable network experiments. There was discussion of adding this functionality, but nothing has been planned yet. Presumably this would look very similar to what congest does.

If this functionality is being planned for, then I think we can confidently continue to maintain these experiment setups. If we don't have plans to add this functionality to knuu, it might be better to focus on infrastructure that can do this so that we have a reliable network setup.

alternative to using congest, we could alternatively abstract some of the functionality of the network test setup code here so that it works both for things like knuu and pulumi

@staheri14
Copy link
Contributor Author

@evan-forbes Thanks for your insights, then are you proposing to hold off on removing the e2e benchmark tests targeting the larger block sizes i.e., this issue?

@evan-forbes
Copy link
Member

are you proposing to hold off on removing the e2e benchmark tests targeting the larger block sizes i.e., this issue?

If we are going to have network tests, then I think that we need the option for bigger block sizes, but in that comment I was unsure if we were having knuu based network tests.

we had a sync today to discuss this, and we're investigating how much effort it would be to develop a pulumi / ansible esque backend for knuu so that we could have network tests that use the same code as our e2e tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testing items that are strictly related to adding or extending test coverage
Projects
None yet
2 participants