onReady callback causes infinite loop in template.autorun

[cormip]

Sample code below with onReady callback goes into an infinite AUTORUN loop:

Template.users.onCreated(function() {
    const template = this
    template.usersReady = new ReactiveVar(false)
    template.userLimit = new ReactiveVar(10)
    template.autorun(function() {
        console.log('AUTORUN')
        const subUsers = subsCache.subscribe('users', template.userLimit.get(), {
            onReady: function () {
                template.usersReady.set(true)
            }
        })
    })
})

The code below does not:

Template.users.onCreated(function() {
    const template = this
    template.usersReady = new ReactiveVar(false)
    template.userLimit = new ReactiveVar(10)
    template.autorun(function() {
        console.log('AUTORUN')
        const subUsers = subsCache.subscribe('users', template.userLimit.get())
        if (subUsers.ready()) {
            template.usersReady.set(true)
        }
    })
})

[jankapunkt]

Onready makes the autorun useless so just call it outside.

[cormip]

If I don't use autorun, then the subscription doesn't rerun when a parameter the subscription depends on gets updated. In the example above:

template.userLimit.get()

[jankapunkt]

Okay I overlooked this. In such case, would it work if you omit assigning the subscription value to a variable that is declared inside autorun? Furthermore, I would also try to play with Tracker.nonReactive for those vars that are not supposed to affect the current autorun computation:

Template.users.onCreated(function() {
    const template = this
    template.usersReady = new ReactiveVar(false)
    template.userLimit = new ReactiveVar(10)
    template.autorun(function() {
        console.log('AUTORUN')
        // avoid introducting a new reactive data source:
        subsCache.subscribe('users', template.userLimit.get(), {
            onReady: function () {
                 // avoid deps.changed call by using:
                Tracker.nonReactive(() => template.usersReady.set(true))
            }
        })
    })
})

Does that help? I am just asking this much to see, if the issue is rather a Blaze/Tracker issue or if it's really caused by this package.

[cormip]

Tried your code sample. It still goes into an infinite loop. Not assigning the variable also wouldn't be ideal, because further manipulation of that cached subscription would then not be possible.