Fix types of SideNavMenuItem
#17609
Open
Fix types of SideNavMenuItem
#17609
+4
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for v11-carbon-react ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #17609 +/- ##
=======================================
Coverage 77.07% 77.07%
=======================================
Files 409 409
Lines 14021 14021
Branches 4307 4355 +48
=======================================
Hits 10807 10807
Misses 3044 3044
Partials 170 170 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #17608
Since
SideNavMenuItemforwards its props toLink, I think the type should beComponentProps<typeof Link>, plus the extra prop thatSideNavMenuItem(isActive). While technically unnecessary for the type system, I've left the extra props in the declaration to keep their descriptions in the docs.Changelog
Changed
SideNavMenuItemPropscorrectly describes the propsSideNavMenuItemsupports. This change includes adding the "as" prop, which was supported bySideNavMenuItembut showed a type error when used.Testing / Reviewing
I'm not sure how best to test. There's a repro in #17608. If I should do something else to make reviewing easier, please let me know.