Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Old information of bio signals persists even if FSS/DSS shows current state is different #189

Open
athulin opened this issue Aug 9, 2023 · 2 comments
Assignees
Labels

Comments

@athulin
Copy link

athulin commented Aug 9, 2023

What is your commander name
A. Thulin

What version are you running
7.3.1 on latest EDCM (5.9.4+6e8f881)

Describe the bug
The plugin does not always reflect 'reality', but instead presents other information, presumably from some kind of canonn backend.

To Reproduce
I'm running Odyssey
Visit Pencil Sector BA-A d40
FSS
Verify that plugin shows:
image

(It also shows similar info under MissingData)
Note that bodies 4c, 4d, 4e and 4f all are identified as having between 2 and 5 bio signals.

Next, in game, show planet information..
Verify:
image

image

image

image

Note that no view shows any bio signals.

DSS 4f.
Verify that in game info still doesn't contain any signs of life.
Verify that plugin stills shows that 4f has 5 life signals.
Verify that canonn-signals page still show 5 signals for 4f.

The plugin does not show 'reality', nor does information (seem to) get updated, either on FSS or DSS.

Expected behavior
Without any clear statement as to what the plugin should show, I expect it show 'reality', i.e. the results from latest FSS and DSS scans.
If the plugin has 'old' info prior to FSS/DSS, it might show that but with a clear indication that it is old, but I don't expect it to persist once real info has been obtained

Once FSS or DSS has provided 'real information' I expect the plugin to show that.

I'm not sure how the discrepancy with the backend info should be handled (or even if and how it is handled). But it seems wrong to allow old data to persist unflagged.

Screenshots
(See above)

Log Files

Additional context
I have not experimented with the plugin settings: there's nothing that suggests it is relevant for this situation.

This might be the same or closely related to the earlier bugs I have submitted: #181 and #188.

@athulin athulin added the bug label Aug 9, 2023
@athulin athulin changed the title [BUG] [BUG] Old information of bio signals persists even if FSS/DSS shows current state is different Aug 9, 2023
@NoFoolLikeOne
Copy link
Collaborator

Its a known issue. Where spansh has outdated Biology info that is no longer in game, there is no message that can tell spansh to update it. Its a particular issue with former bark mound locations becaus ethey have no volcanism to update the signals.

The new version of the plugin is able to check that the update time of the signals is earlier than the update time of the body and will suppress any signals that arent up to date.

This is the result.
image

I presume you didnt rescan those remaining bodies?

You have reminded me that the signals page needs the same update.

A full solution would require some complex interaction between different signals and for the plugin to correct the display after a body scan but that is quite a job and really required about 4000 lines of code to be re-written from scratch.

It would not help with the signals page.

I think it might be better to restore the ex-barkmounds so that at least those bodies where barkmounds were previously detected would be displayed as "ex-bark mounds" but there may still be thousands of ex-bark mound locations that are in Spansh as Biology but do not have any corresponding Composition Scans.

The short answer is that there is no easy solution.

@athulin
Copy link
Author

athulin commented Aug 10, 2023

Thanks for your response.

If it's a known issue, fine. In that case, I probably didn't use the right search terms when I tried to look for it.

I only scanned 4f of the mentioned bodies with no bio in-game, but with bio in plugin. As it didn't cause any updates, I assumed you would need one or two for your own tests.

Now that I know that bio/no-bio is a known issue, I won't report any further in case I come across them. I'm testing the EDMC-Bioscan plugin (which lists non-horizon bio) vs the BioInsight plugin (which currently doesn't), and initially at least have been using EDMC-Canonn plugin as 'truth' as regards Horizon biosI have been a bit confused by all the differences.

You mention a 'new version of the plugin'. Which particular version is that? The latest version seems to be 7.3.1 based on the first page. But perhaps your refer to a coming release?

Feel free to close this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants