Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Checkbox to edit debug #109

Open
chennin opened this issue Aug 5, 2021 · 3 comments
Open

[BUG] Checkbox to edit debug #109

chennin opened this issue Aug 5, 2021 · 3 comments
Assignees
Labels

Comments

@chennin
Copy link

chennin commented Aug 5, 2021

What is your commander name
Floor Jansen

What version are you running
6.3.0. Auto-updated from some older version, possibly 6.2.1.

Describe the bug
According the wiki, there should be a check box to enable/disable debugging. I would like to disable debug logging, because it's making it harder to debug a different EDMC problem. However, this checkbox is not present.

To Reproduce
Open the Settings dialog.

EDMC 5.1.2
Canonn plugin 6.3.0

Expected behavior
Check box present and reduces log spam when not checked

Screenshots
https://cdn.discordapp.com/attachments/331059145388064768/872671652624875590/unknown.png

Additional Context
I cloned the repo and grepped the whole repo (both master and develop branches) for the string and was unable to find Turn on Debugging. Is the wiki description premature?

~/EDMC-Canonn$ grep -Ir "Auto Update"
canonn/release.py:        nb.Checkbutton(frame, text="Auto Update This Plugin",
~/EDMC-Canonn$ grep -Ir "Turn on"
~/EDMC-Canonn$
@chennin
Copy link
Author

chennin commented Aug 6, 2021

Discussion from Discord -

EDMC is set to INFO: https://cdn.discordapp.com/attachments/331059145388064768/872995809594068992/unknown.png

But after I double-checked that and restarted EDMC, I'm still getting Canonn DEBUG logs. Here's the log:
EDMarketConnector.log

So it looks like there's (1) a documentation bug about the Canonn setting being present, and (2) another bug where debug logging is going when it's not supposed to. This bug might be in EDMC.

@chennin
Copy link
Author

chennin commented Aug 6, 2021

And update on the logging issue, was an EDMC bug: EDCD/EDMarketConnector@6e7ef6d

@NoFoolLikeOne NoFoolLikeOne changed the title [BUG] [BUG] Checkbox to edit debug Aug 15, 2021
@NoFoolLikeOne
Copy link
Collaborator

EDMC is introducing a new feature to allow local control we will add that in

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants