ci: subiquity-check check stage-packages

[Chris-Peterson444]

I'd like to propose an additional check to the subiquity-check script to check for any stage-packages differences.
Is this the right branch to open the PR against? Or should it go against main?

I skip comparing the WSL specific packages because that's not something subiquity specifies and I'm not sure about the details on why those are under subiquitydeps in particular or if those still needs to be there.

[d-loose]

Thanks a lot, this is really helpful!

I think the WSL specific dependencies can be safely removed now that the WSL OOBE has been deprecated (see internal spec WS030).

Do you want to make the necessary changes to the snapcraft.yaml in this PR, or should I do it separately?

Just to double-check, the changes would be:

diff --git a/snap/snapcraft.yaml b/snap/snapcraft.yaml
index 7a8174f97..9e0bf889a 100644
--- a/snap/snapcraft.yaml
+++ b/snap/snapcraft.yaml
@@ -116,8 +116,6 @@ parts:
     stage-packages:
       # This list includes the dependencies for curtin and probert as well,
       # there doesn't seem to be any real benefit to listing them separately.
-      - cloud-init
-      - dctrl-tools
       - iso-codes
       - libpython3-stdlib
       - libpython3.10-minimal
@@ -147,9 +145,6 @@ parts:
       - python3.10-minimal
       - ssh-import-id
       - ubuntu-advantage-tools
-      # WSL specifics:
-      - language-selector-common
-      - locales
     prime:
       - -lib/systemd/system/*

[d-loose]

P.S. is it worth adding this check to the snap/ubuntu-desktop-bootstrap/24.04 branch as well and clean up the stage-packages there too?

[Chris-Peterson444]

I think the WSL specific dependencies can be safely removed now that the WSL OOBE has been deprecated (see internal spec WS030).

Thanks for the link! Yeah looks like that's a safe removal. I went ahead and rebased my changes to not expect a WSL portion to cut out since we're going to remove it.

Do you want to make the necessary changes to the snapcraft.yaml in this PR, or should I do it separately?

Either is fine. All of the changes look right to me too.

P.S. is it worth adding this check to the snap/ubuntu-desktop-bootstrap/24.04 branch as well and clean up the stage-packages there too?

Yeah I think so. I'll open another PR for that.