From 56a6baeee80a0c5ea87a5fd2e34d609832afa3d6 Mon Sep 17 00:00:00 2001 From: Zeyad Gouda Date: Mon, 1 Jul 2024 16:34:29 +0300 Subject: [PATCH] o/hookstate/ctlcmd: explain why configure hook is not tested for single transaction Signed-off-by: Zeyad Gouda --- overlord/hookstate/ctlcmd/services_test.go | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/overlord/hookstate/ctlcmd/services_test.go b/overlord/hookstate/ctlcmd/services_test.go index 863b28b31a13..bebe33234f38 100644 --- a/overlord/hookstate/ctlcmd/services_test.go +++ b/overlord/hookstate/ctlcmd/services_test.go @@ -689,6 +689,17 @@ func (s *servicectlSuite) TestQueuedCommandsOrderingConfigureHook(c *C) { s.testQueuedCommandsOrdering(c, hook, singleTransaction) } +// NOTE: It is tricky to get snap name for all task kinds in the case of configure hook +// so this test is left commented out just for clarity, but it will fail. +// This is a non-issue for configure hook since the command tasks are queued at the very +// end of the change unlike the default-configure hook. +// +// func (s *servicectlSuite) TestQueuedCommandsOrderingConfigureHookSingleTransaction(c *C) { +// const hook = "configure" +// const singleTransaction = true +// s.testQueuedCommandsOrdering(c, hook, singleTransaction) +// } + func (s *servicectlSuite) testQueueCommandsConfigureHookFinalTask(c *C, finalTaskKind string) { s.st.Lock()