-
Notifications
You must be signed in to change notification settings - Fork 930
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backports (stable-5.0) #14187
Merged
Merged
Backports (stable-5.0) #14187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: hamistao <[email protected]> (cherry picked from commit 3fa5fb1)
Closes canonical#507 Signed-off-by: Stéphane Graber <[email protected]> (cherry picked from commit e39888708011f980edce8fb4bda7f13caac3ef7d) Signed-off-by: Thomas Parrott <[email protected]> License: Apache-2.0 (cherry picked from commit 9e36c17)
Signed-off-by: Din Music <[email protected]> (cherry picked from commit 61a1d65)
Signed-off-by: Kadin Sayani <[email protected]> (cherry picked from commit 2704b3e)
Signed-off-by: Mark Laing <[email protected]> (cherry picked from commit 6eddace)
`msg` only contains stdout from the child process, so this wasn't passing back any information about what actually failed. Signed-off-by: Wesley Hershberger <[email protected]> (cherry picked from commit bed72f0)
Signed-off-by: Stéphane Graber <[email protected]> (cherry picked from commit c8fbf1b1c5a40f8443f49a6bb2628602c8a63edb) Signed-off-by: Kadin Sayani <[email protected]> License: Apache-2.0 (cherry picked from commit bb44d25)
Signed-off-by: Stéphane Graber <[email protected]> (cherry picked from commit b3a97198f86cfadea9ee3f1c6181ee67bea418a3) Signed-off-by: Kadin Sayani <[email protected]> License: Apache-2.0 (cherry picked from commit 4a7208a)
Signed-off-by: Wesley Hershberger <[email protected]> (cherry picked from commit e8542c6)
Signed-off-by: Stéphane Graber <[email protected]> (cherry picked from commit a91b193660f4c8c5d298a49e6a889654ed35194a) Signed-off-by: Wesley Hershberger <[email protected]> License: Apache-2.0 (cherry picked from commit 849b1de)
Signed-off-by: Simon Deziel <[email protected]> (cherry picked from commit 8461945)
Signed-off-by: Simon Deziel <[email protected]> (cherry picked from commit 1820e9f)
Signed-off-by: Simon Deziel <[email protected]> (cherry picked from commit 4dfdce2)
Signed-off-by: Simon Deziel <[email protected]> (cherry picked from commit fd59bda)
Signed-off-by: Simon Deziel <[email protected]> (cherry picked from commit 5baa186)
Signed-off-by: Simon Deziel <[email protected]> (cherry picked from commit fb59aa5)
Signed-off-by: Simon Deziel <[email protected]> (cherry picked from commit 18552eb)
Signed-off-by: Simon Deziel <[email protected]> (cherry picked from commit 3abc4e0)
Signed-off-by: Thomas Parrott <[email protected]>
Signed-off-by: Thomas Parrott <[email protected]>
Signed-off-by: Stéphane Graber <[email protected]> Signed-off-by: hamistao <[email protected]> License: Apache-2.0 (cherry picked from commit 8c48af1)
Closes lxc/incus#256 Signed-off-by: Stéphane Graber <[email protected]> Signed-off-by: hamistao <[email protected]> License: Apache-2.0 (cherry picked from commit 8665ae0)
When the VM disconnects due to a stop/reboot, the socket is closed and the error we get is a `connection reset by peer` or a `Unexpected EOF` instead of a EOF. So this helps handle these errors similarly to make the command exit cleanly in these scenarios. Since both errors are of type errorString, the only way to check it is to see if they contains the expected substring. Signed-off-by: hamistao <[email protected]> (cherry picked from commit 0f5be4b)
Signed-off-by: Thomas Parrott <[email protected]>
Signed-off-by: Thomas Parrott <[email protected]>
Signed-off-by: Thomas Parrott <[email protected]>
Signed-off-by: Thomas Parrott <[email protected]>
Signed-off-by: Thomas Parrott <[email protected]>
MusicDin
approved these changes
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.