Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wwan_resource output is not RFC822 compliant if firmware revision is multi-line #1505

Open
pieqq opened this issue Sep 26, 2024 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@pieqq
Copy link
Collaborator

pieqq commented Sep 26, 2024

Bug Description

On a device (202408-34247) with a MTK WWAN, there is an issue when the wwan_resource job is launched:

WARNING:plainbox.ctrl:local script com.canonical.certification::wwan_resource returned invalid RFC822 data: Unexpected non-empty line: '0060\n' (line 6)

This is because one of the field is not escaped and runs on multiple lines (see logs below)

To Reproduce

  1. Launch checkbox-cli run com.canonical.certification::wwan_resource
  2. Observe the firmware_revision field runs on two lines instead of one

Environment

Checkbox dev

Relevant log output

wwan_resource outcome:


ubuntu@localhost:~$ checkbox-cli run com.canonical.certification::wwan_resource
Skipped file: /usr/share/checkbox-provider-base/units/camera/README.rst
Skipped file: /usr/share/checkbox-provider-base/units/snapd/README.md
Skipped file: /usr/share/checkbox-provider-base/units/stress/suspend_cycles_reboot.md
===========================[ Running Selected Jobs ]============================
==============[ Running job 1 / 1. Estimated time left: 0:00:03 ]===============
--------------------[ Gather device info about WWAN modems ]--------------------
ID: com.canonical.certification::wwan_resource
Category: com.canonical.certification::wwan
... 8< -------------------------------------------------------------------------
mm_id: 1
hw_id: 357953120018642
manufacturer: mtk
model: MBIM [14C0:4D75]
firmware_revision: RMM-G1.10.00.060_GC
0060
hardware_revision: MTK2

------------------------------------------------------------------------- >8 ---
Outcome: job passed
local script com.canonical.certification::wwan_resource returned invalid RFC822 data: Unexpected non-empty line: '0060\n' (line 6)
Finalizing session that hasn't been submitted anywhere: checkbox-run-2024-09-26T07.12.55
==================================[ Results ]===================================
 ☑ : Gather device info about WWAN modems

MMCLI info:

ubuntu@localhost:~$ mmcli -L
    /org/freedesktop/ModemManager1/Modem/1 [mtk] MBIM [14C0:4D75]


### Additional context

_No response_
@pieqq pieqq added the bug Something isn't working label Sep 26, 2024
Copy link

Thank you for reporting us your feedback!

The internal ticket has been created: https://warthogs.atlassian.net/browse/CHECKBOX-1589.

This message was autogenerated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants