Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(connectors): add docs for secure TLS connexion #4029

Merged
merged 4 commits into from
Jul 15, 2024
Merged

docs(connectors): add docs for secure TLS connexion #4029

merged 4 commits into from
Jul 15, 2024

Conversation

mathias-vandaele
Copy link
Contributor

@mathias-vandaele mathias-vandaele commented Jul 12, 2024 •
edited
Loading

Description

closes camunda/connectors#2806

For self-managed connectors, we did not provide an easy way of setting up a custom certificate for zeebe client, this PR fixes this.

When deploying using those env variables, zeebe will now use the given certificate to set up a secure connection to the zeebe client

When should this change go live?

  • This is a bug fix, security concern, or something that needs urgent release support.
  • This is already available but undocumented and should be released within a week.
  • This on a specific schedule and the assignee will coordinate a release with the DevEx team. (apply hold label or convert to draft PR)
  • This is part of a scheduled alpha or minor. (apply alpha or minor label)
  • There is no urgency with this change and can be released at any time.

PR Checklist

  • My changes are for an already released minor and are in /versioned_docs directory.
  • My changes are for the next minor and are in /docs directory (aka /next/).

@github-actions GitHub Actions
Copy link
Contributor

👋 🤖 🤔 Hello! Did you make your changes in all the right places?

These files were changed only in docs/. You might want to duplicate these changes in versioned_docs/version-8.5/.

  • docs/self-managed/connectors-deployment/connectors-configuration.md

You may have done this intentionally, but we wanted to point it out in case you didn't. You can read more about the versioning within our docs in our documentation guidelines.

sbuettner
sbuettner previously approved these changes Jul 15, 2024
View reviewed changes
@mathias-vandaele @github-actions
Update docs/self-managed/connectors-deployment/connectors-configurati…
1b37fe5 
…on.md

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@mathias-vandaele @github-actions
Update docs/self-managed/connectors-deployment/connectors-configurati…
8d19835 
…on.md

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@ev-codes
Copy link
Contributor

ev-codes commented Jul 15, 2024 •
edited
Loading

@mathias-vandaele thanks, looks good!

I went ahead and capitalized terms that needed it (e.g., Zeebe). In public-facing docs, it's best to follow convention for easier reading 😄

@mathias-vandaele mathias-vandaele merged commit 5ac7249 into main Jul 15, 2024
7 checks passed
@mathias-vandaele mathias-vandaele deleted the 679-improvement-suggestion-self-signed-certificates branch July 15, 2024 09:28
@akeller akeller added the component:connectors Issues related to the connectors project. label Jul 15, 2024
@akeller
Copy link
Member

akeller commented Jul 15, 2024

Hey there! Please be sure to fill out the PR description and add labels. This helps the DevEx team, specifically the technical writers, know how and when to review and release the docs. Also, be sure to link back to Product Hub epics or team board issues so we have more context about this change, as we often try to do some validation (is this change properly backported, are there other areas that need to be changed as well, etc.).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ev-codes ev-codes ev-codes approved these changes

@sbuettner sbuettner sbuettner left review comments

Assignees
No one assigned
Labels
component:connectors Issues related to the connectors project.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve the way Connectors handle certificates
4 participants
@mathias-vandaele @ev-codes @akeller @sbuettner