Skip to content
This repository has been archived by the owner on Nov 12, 2017. It is now read-only.

Welcome - GitHub Etiquette #6

Open
joenash opened this issue Oct 21, 2017 · 4 comments
Open

Welcome - GitHub Etiquette #6

joenash opened this issue Oct 21, 2017 · 4 comments

Comments

@joenash
Copy link

joenash commented Oct 21, 2017

There are numerous aspects of etiquette we want to enforce. Some are true for all of GitHub, some are true for experts.

In particular for experts, we want to discourage students adding reviewers, or tagging reviewers, or asking for review. Prefect should post a warning to students who do this.

@KaiFish
Copy link

KaiFish commented Oct 21, 2017

I think a video to guide students through their first pull request and explain the way the reviewing system works would be help a lot with these issues
mentioned it in #4

@joenash
Copy link
Author

joenash commented Oct 21, 2017

@KaiFish I don’t want us to start getting into details about how the reviewing system works publicly, because it makes it harder to change and also sets rigid expectations for performance that we might struggle to provide. However I do definitely want to provide clearer guidance on the first PR, might make a series of gifs to embed in the instructions

@KaiFish
Copy link

KaiFish commented Oct 21, 2017

I didn't mean details, more so telling people to tag it properly and leave it alone, and you will see reviews eventually. so that you don't get blasted with comments from new people asking when it will be reviewed.

@joenash
Copy link
Author

joenash commented Oct 22, 2017

Gotcha 👍

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants