Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto Component suggestion dont work with TextBlocks #823

Open
erayerdem opened this issue Apr 26, 2023 · 11 comments
Open

Auto Component suggestion dont work with TextBlocks #823

erayerdem opened this issue Apr 26, 2023 · 11 comments

Comments

@erayerdem
Copy link

Hello team , auto suggestion is dont work for text blocks, I think title is very clear I will add a screenshot for this am I missing some topic

Screenshot 2023-04-26 at 14 11 56

@erayerdem
Copy link
Author

Screenshot 2023-04-26 at 14 12 46

@erayerdem
Copy link
Author

if you ask me , we can create a task for core-camel for this style route definition what dou you think guys
Screenshot 2023-04-26 at 14 18 20

@davsclaus
Copy link
Collaborator

Ah okay so this is the new JDK17 text blocks with 3 x double quotes. Yeah that may be something special we need to add into the plugin to support.

Maybe @essobedo finds some time to work on this

@essobedo
Copy link
Contributor

essobedo commented May 5, 2023

@davsclaus This kind of syntax is not even supported by Camel core so it is normal that the plugin doesn't accept it. IMHO, I'm not sure that it makes sense to allow to add carriage return characters in a middle of a URI. WDYT?

@davsclaus
Copy link
Collaborator

Ah yeah before text blocks you would have to concat multiple strings

"aaa"
"bbb" +
"ccc" +

But I see a good reason to make end users organize URIs more readable if they use text blocks where parameters can be on multiple lines.

So I wonder if we should then parse the text block and remove text blocks, and trim.

This is also what you can do in XML where an uri attribute can be in a block

@essobedo
Copy link
Contributor

essobedo commented May 9, 2023

I'm not sure if my last comment was clear enough so let me reformulate. The text block is not really the problem here, the real problem is the fact that endpoint URIs with carriage return characters are not yet supported by Camel so adding the support in the plugin if you can't start your route would be useless and potentially misleading.

So if it makes sense for you to support URIs with carriage return characters then we need to implement it into Camel first and then add the support to the plugin.

@davsclaus
Copy link
Collaborator

Okay we should add support for this in Camel 4.x since its java 17 based.

@davsclaus
Copy link
Collaborator

@davsclaus
Copy link
Collaborator

Okay this will require Camel 4.2 onwards.

@davsclaus davsclaus added this to the 1.2.0 milestone Oct 22, 2023
@davsclaus
Copy link
Collaborator

Okay 4.2.0 is to be released soon that has text block support.

When we have updated, can we then check if this works in this plugin. Otherwise @essobedo if you still want to work a bit on this plugin then you are welcome to help with what to fix in the plugin source for text block support

@essobedo essobedo reopened this Nov 14, 2023
@essobedo
Copy link
Contributor

ok, I will check it asap

@davsclaus davsclaus modified the milestones: 1.2.0, 1.2.1 Nov 15, 2023
@davsclaus davsclaus modified the milestones: 1.2.1, 1.2.2 Jan 17, 2024
@davsclaus davsclaus modified the milestones: 1.2.3, 1.2.4 Feb 21, 2024
@davsclaus davsclaus removed this from the 1.2.4 milestone Mar 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants