Building for archive to upload to app store fails

[bartlomein]

Description

Product -> Archive produces several bugs and the build fails. One is in hermes-engine and another one says it is being built forvisionOS-simulator even though "Any VisionOS Device" is selected in the top build menu

Steps to reproduce

Open Xcode and follow steps to build for App store deployment.
Build app.

React Native Version

0.73.4-1

Affected Platforms

Other (please specify)

Output of npx react-native info

none

Stacktrace or Logs

none

Reproducer

none

Screenshots and Videos

[bartlomein]

I commented out the use of vsnprintf inside of Logging.cpp and it worked. However I'm guessing thats not a long term solution

[okwasniewski]

I think at the current state of the project (building Hermes from source) you might need to clean the build folder before archiving so inside of visionOS folder:

1. rm -rf Pods build
2. Install pods again
3. Build the app for release

I'm waiting for CMake 3.28.4 to be released with important fixes which will unblock us for moving forward with shipping a precompiled version of Hermes engine

[okwasniewski]

Looks like this is a duplicate of #128 as the same issues are described by other people there - let's keep one of them open.