Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow arbitrary images #66

Closed
ddavidebor opened this issue Aug 15, 2017 · 5 comments
Closed

allow arbitrary images #66

ddavidebor opened this issue Aug 15, 2017 · 5 comments

Comments

@ddavidebor
Copy link

it would be really really nice if buidbot_travis allowed arbitrary docker images to be used, in a way similar to what wercker-ci and drone-ci allow.

This could be implemented separately by the language tag with a "box" tag,

What do you think about it?

@seankelly
Copy link
Member

I do this by using a renderer for the image.

@ddavidebor
Copy link
Author

@seankelly do you have an example you can share ?

@seankelly
Copy link
Member

With #62, properties are set for os, dist, and language. I use OpenStackLatentWorker, so something like:

c['workers'].append(worker.OpenStackLatentWorker(
    ...
    block_devices=[
        {'uuid': travis_image,
        'volume_size': 10}])
))

@util.renderer
def travis_image(props):
    ...

With the extra properties available, I can make a decision on which image to use based on the dist and language.

@ddavidebor
Copy link
Author

ddavidebor commented Aug 17, 2017

Mmmh, got it.

I'm still interested in a discussion for this to be implemented in a way that supports the usability intended for buildbot_travis.

@tardyp
Copy link
Member

tardyp commented Sep 4, 2017

you can use following:

%(prop:docker-image:-buildbot/buildbot-worker)s

in docker image configuration

image

Note that It actually didn't work before #65

@tardyp tardyp closed this as completed Sep 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants