-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add GHA manual execution notice #620
Conversation
README.md
Outdated
@@ -14,3 +14,7 @@ For help and discussion regarding Protobuf plugins, join us on [Slack](https://b | |||
|
|||
For feature requests, bugs, or technical questions, email us at [[email protected]]([email protected]). | |||
|
|||
## Manual action caveats | |||
|
|||
When triggering a manual execution of the `fetch versions` workflow, you may want to disable the scheduled execution |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The top-level README is more meant for consumers of the plugins from this repo. We should add this sort of info to CONTRIBUTING.md instead.
.github/workflows/fetch_versions.yml
Outdated
# Run once a day at 10 AM EST | ||
- cron: "0 14 * * *" | ||
# Run once a day at 8 AM EST | ||
- cron: "0 12 * * *" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I preferred this run during work hours in the morning since this is when we usually get to these issues.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the rationale for changing this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ahh, okay. The idea here was that they'd be ready to go when you get in in the morning. So you wouldn't need to wait til the scheduled one or manually trigger
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should receive notifications in Slack about the presence of the PR to remind you, given that you're being assigned
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typically this runs and alerts us when we are online, it's a good reminder to deal with this repository. Instead of dealing with the backlog of issues that accumulated.
@pkwarren and I get assigned (I can't speak for Philip) but I preferred this run when we're online instead of earlier in the day.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For some context, we had a bit of a discussion here #471 it used to run the night before (effectively before we get in), and we were trying out the later time.
No description provided.