Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add connect-swift v0.6.0 and validate v1.0.2 plugins #619

Merged
merged 3 commits into from
Jun 27, 2023
Merged

Conversation

app-token-plugins[bot]
Copy link
Contributor

New plugin versions found. Please review.

@pgmitche pgmitche requested a review from pkwarren June 27, 2023 14:02
@pkwarren pkwarren changed the title Found new plugin versions Add connect-swift v0.6.0 and validate v1.0.2 plugins Jun 27, 2023
@pgmitche
Copy link
Contributor

@pkwarren I was just about to remove validate v1.0.2, as it looks like you typically only update one at a time? Do you want me to push that change?

@pkwarren
Copy link
Member

@pkwarren I was just about to remove validate v1.0.2, as it looks like you typically only update one at a time? Do you want me to push that change?

We sometimes do that as a precaution when updating protoc or gRPC bazel build plugins, as they can take forever to run and we've had one instance where it failed without breaking it into smaller changes. For these plugins however, it shouldn't be an issue to merge together.

FYI I've manually bumped the plugin dependencies to the latest version so we should be ready to go if things look ok to you.

@pgmitche
Copy link
Contributor

pgmitche commented Jun 27, 2023

We sometimes do that as a precaution when updating protoc or gRPC bazel build plugins, as they can take forever to run and we've had one instance where it failed without breaking it into smaller changes. For these plugins however, it shouldn't be an issue to merge together.

FYI I've manually bumped the plugin dependencies to the latest version so we should be ready to go if things look ok to you.

LGTM 👍🏼

@pgmitche pgmitche merged commit 7dcc0f9 into main Jun 27, 2023
3 checks passed
@pgmitche pgmitche deleted the fetch-versions branch June 27, 2023 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants