Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistency in color spec enforcement #202

Open
KristianLyng opened this issue Nov 6, 2016 · 0 comments
Open

Inconsistency in color spec enforcement #202

KristianLyng opened this issue Nov 6, 2016 · 0 comments

Comments

@KristianLyng
Copy link

For graphite-web I can/could use bgcolor=222222 instead of bgcolor=#222222, but not so for gridline colors.

For graphite-api 1.1.3 both require the # prefix, but colorList still doesn't.

The examples might also suggest encoding it with %23 as that is generally required for browsers too.

So far this is my roundoup:

gridLineColor: Requires # all over
bgcolor: requires # in graphite-api 1.1.3 but not graphite-web 0.9.15
fgcolor: requires # in graphite-api 1.1.3 but not graphite-web 0.9.15
colorList: # is optional for both

I'm guessing this means color-parsing isn't as generic as it should be.

Since graphite-web 0.9.15 is also inconsistent, I suppose there's a choice to be made: Match the inconsistency or fix them. Right now, it's neither one or the other.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant