Url Management Refactor #70
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
URL Manager is now a singleton object rather than a class with static members
All URL related classes have been refactored into package cz.brmlab.yodaqa.provider.url
URL sets are now stored in dict map json object instead of a 2D array.
All URLs have a key associated with them located in cz.brmlab.yodaqa.provider.url.UrlConstants, where the constant acts as both the System.property override (the CLI -D flag) and the key in the json dict map. This also keeps the set of urls easy to extend w/o breaking existing functionality, as you can add new urls into the json dict map, and just add a new constant in the UrlConstants class that any new classes can depend on.