Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question about GlobalObject #36

Closed
tbrannam opened this issue Feb 28, 2024 · 2 comments
Closed

Question about GlobalObject #36

tbrannam opened this issue Feb 28, 2024 · 2 comments

Comments

@tbrannam
Copy link
Contributor

I've been looking at the implementation of GlobalObject and was thinking through the implications for my project. I have a use case where a common Node runtime is being used by several Modules, of which several could consume react-streaming (similar to a plugin model). These are intended to be isolated from each other.

The implementation of getGlobalObject using a non-unique key projectKey would make these collide. Are there alternatives such as import.meta.url that would namespace to an actual module instead make this more flexible?

I don't fully understand the underlying problem getGlobalObject is trying to solve, so I'm not sure this would run counter to your goals.

@brillout
Copy link
Owner

I think supporting such use case should be outside of the scope of the project.

Feel free to fork, or elaborate on why your use case is important to you and I may reconsider, or PR welcome if it turns out to be an easy fix. Alternatively: sponsoring welcome to increase the priority for this.

@brillout brillout closed this as not planned Won't fix, can't repro, duplicate, stale Feb 28, 2024
@tbrannam
Copy link
Contributor Author

I will investigate and see if I can create a PR. I wasn't sure if the problem globalObject is fixing is covered by tests. We'll see

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants