Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to translate certain pages from context menu #4150

Open
srirambv opened this issue Apr 17, 2019 · 2 comments
Open

Unable to translate certain pages from context menu #4150

srirambv opened this issue Apr 17, 2019 · 2 comments
Labels
bug feature/translate priority/P3 The next thing for us to work on. It'll ride the trains. QA/Test-Plan-Specified QA/Yes

Comments

@srirambv
Copy link
Contributor

Description

Unable to translate certain pages from context menu

Steps to Reproduce

  1. Visit https://ja.wikipedia.org/wiki/ in nightly
  2. Right click on page and click on Translate
  3. First time it shows translation failed
  4. Right click second time and click on translate
  5. Shows trasnlated but only few words actually get translated.

Actual result:

Unable to translate certain pages from context menu

Expected result:

Should translate all pages

Reproduces how often:

Easy

Brave version (brave://version info)

Brave 0.65.56 Chromium: 74.0.3729.75 (Official Build)nightly (64-bit)
Revision fdb7915642fef8cf997beac2554709d148e3c187-refs/branch-heads/3729@{#754}
OS Linux

Version/Channel Information:

  • Can you reproduce this issue with the current release?
    No

  • Can you reproduce this issue with the beta channel?
    No

  • Can you reproduce this issue with the dev channel?
    Dev just shows translating bubble but doesn't actually translate it

  • Can you reproduce this issue with the nightly channel?
    Yes

Miscellaneous Information:

brave/go-translate#2
cc: @yrliou

@yrliou
Copy link
Member

yrliou commented Apr 17, 2019

Translation failed because there was a translate request involved more than the maximum elements MS api allowed for a single request, will need to handle this in go-translate.

@rebron rebron added the priority/P3 The next thing for us to work on. It'll ride the trains. label Apr 19, 2019
@srirambv
Copy link
Contributor Author

+1 from @GeetaSarvadnya via #4532

@yrliou yrliou removed their assignment Nov 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug feature/translate priority/P3 The next thing for us to work on. It'll ride the trains. QA/Test-Plan-Specified QA/Yes
Projects
Status: P3 Backlog
Development

No branches or pull requests

3 participants