Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

font-awesome <span> -> <li> #389

Open
Tetdoss opened this issue Aug 15, 2015 · 3 comments
Open

font-awesome <span> -> <li> #389

Tetdoss opened this issue Aug 15, 2015 · 3 comments
Milestone

Comments

@Tetdoss
Copy link

Tetdoss commented Aug 15, 2015

Hello, your bundle works fine with font-awesome but font-awesome use < li > instead of < span > to display icon. It doesn't change anything but there are issues with others plugins.

For example, i'm using AdminLTE which uses font-awesome but when i want to use your {{icon...}} twig function, it is replaced with < span > and the css of AdminLTE doesn't handle < span > to display icon.

So can you normalize your bundle and use < li > instead of < span > for the font-awesome icons ?

Thank you ;)

@vrnagy
Copy link

vrnagy commented Aug 24, 2015

You can change the icon_tag config parameter like:

braincrafted_bootstrap:
    icon_tag: i

@florianeckerstorfer
Copy link
Member

We should totally change the default value to i in a feature release.

@florianeckerstorfer florianeckerstorfer added this to the 2.2 milestone Sep 2, 2015
@Tetdoss
Copy link
Author

Tetdoss commented Sep 19, 2015

Thanks for your answers, in fact I have this issue because i'm using bootstrap (useful for the carousel for example) AND font-awesome icon. But I'll try to use only font-awesome ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants