eks-resource: process paginated results from list-stacks #873
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cfn ListStacks might return paginated results. Go through all results before erroring on missing stack.
ecpullen
approved these changes
Sep 18, 2023
webern
approved these changes
Sep 25, 2023
Comment on lines
+498
to
+501
| return Err(ProviderError::new_with_context( | ||
| Resources::Remaining, | ||
| "Could not find nodegroup cloudformation stack for cluster", | ||
| )); |
There was a problem hiding this comment.
Suggested change
| return Err(ProviderError::new_with_context( | |
| Resources::Remaining, | |
| "Could not find nodegroup cloudformation stack for cluster", | |
| )); | |
| return Err(ProviderError::new_with_context( | |
| Resources::Remaining, | |
| format!("Could not find nodegroup cloudformation stack '{}' | |
| for cluster '{}'", stack.name(), cluster_name), | |
| )); |
There was a problem hiding this comment.
I'll fix this in a follow up after I'm back
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number:
N/A
Description of changes:
Testing done:
I have 150 cloudformation stacks and the cluster resource agent succesfully completes whereas it couldn't because of the pagination issue.
Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.