Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix building on OpenBSD #395

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Conversation

brad0
Copy link

@brad0 brad0 commented Aug 24, 2024

OpenBSD does not have close_range() nor does NetBSD.

OpenBSD needs environ like the other *BSD's.

The build was erroring on kp_pid, it looks like p_pid is appropriate.

Fixes: #391

OpenBSD does not have close_range() nor does NetBSD.

OpenBSD needs environ like the other *BSD's.

The build was erroring on kp_pid, it looks like p_pid is appropriate.
@time-killer-games
Copy link
Contributor

time-killer-games commented Aug 25, 2024

Hey, in case you were wanting to add other features to OpenBSD which are missing such as bp2::ext::exe you can base your code loosely on this file, just like I did with my past contributions to boost process v2:

https://github.com/time-killer-games/xproc/blob/main/process.cpp

Look for the function exe_from_proc_id().

Be sure to change the license from MIT to what boost process v2 has, I give you permission as the copyright holder of the relevent code. Process Hacker developers and devKathy are only responsible for small portions of code specific to the Windows platform, the rest I am the copyright holder for, which means I wrote all OpenBSD-related code, (and *BSD-related code as a whole). Make sure if you use enough of my code to be considered substantial that I am mentioned in the copyright of the related files (refer to me as "Samuel Venable").

I don't really have the time to add these features myself right now, but there is no obligation for you to do so either.

@time-killer-games
Copy link
Contributor

Does this actually build now? If not, let me know once you solve all build errors. @klemens-morgenstern would like me to test this pull request once you are done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Process v2 does not build on OpenBSD
2 participants