Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compose box misleads about whether @'s are links when they are prefixed by symbols #5530

Open
mcclure opened this issue Sep 29, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@mcclure
Copy link

mcclure commented Sep 29, 2024

To Reproduce

Open a compose box. Type a word, a /, and an @ name.

image

The name turns blue. It's a mention now, it's not text. Now, remove the space before the @.

image

The text is still blue. Because it is blue, I believe if I click "Post", it will be a link. Click "Post".

image

It's not!! It's just text! An @ preceded by a symbol is not a link. If you had typed "I am testing/@dryad.technology" the compose box would know that. But I tricked it into misleading signaling by typing whitespace before the @ and then removing the whitespace.

Expected behavior

The compose box should detect when the conditions for an @ to be treated as a link on the server side have been violated, and make the text no longer blue (so the user doesn't think they're going to get a link/mention and then fail to get a link/mention)

Details

  • Platform: Chrome 128.0.6613.138 (Official Build) (64-bit) (cohort: Stable) , Windows 10 Version 22H2 (Build 19045.4894)
    For this test, the account and the UI were both bsky.app web.
@mcclure mcclure added the bug Something isn't working label Sep 29, 2024
@SpriterGors
Copy link

SpriterGors commented Sep 30, 2024

I had a similar situation not too long ago, but mine was suffixed (placed after the @), as follows:

image
Note that the composer makes it look like it is going to generate a clickable link.

image
However upon posting the link breaks and it renders as text.

in both cases (prefixed and suffixed), it seems that deleting the space does not toggle off the link color.

I can understand the link being broken, as it makes sense. However it'd make it more obvious if the composer updated the text color from clickable (blue) to non-clickable (white.)

Build version: 1.91.1; Bundle info: 49ab486 (prod); Bundle date: 24092017; Platform: web
Platform: Firefox 130.0.1 (64-bits)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants