Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Regenerate to support latest protocol messages #140

Open
ES-Alexander opened this issue Jul 31, 2024 · 3 comments
Open

Regenerate to support latest protocol messages #140

ES-Alexander opened this issue Jul 31, 2024 · 3 comments

Comments

@ES-Alexander
Copy link
Contributor

ES-Alexander commented Jul 31, 2024 •
edited
Loading

Ping Python doesn't yet include the new Cerulean Sonar messages.

I believe we just need to re-run the generation, and release a new version.

Raised in this forum thread
@patrickelectric
Copy link
Member

I believe that @NickNothom was working on adding support to it. Sadly I don't have one on hands to develop it.

@ES-Alexander
Copy link
Contributor Author

Ahh, I was forgetting that because it's a new device type it'll need a generate/templates/omniscan450.py.in file, so it's a bit more work than just running the generation process.

@patrickelectric
Copy link
Member

Exactly, as @Williangalvani suggested, it appears that we have the sensor here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@patrickelectric @ES-Alexander