Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@web3-onboard/ledger is missing a dependency on @ethersproject/providers #1806

Closed
1 task done
ghivert opened this issue Jul 5, 2023 · 2 comments · Fixed by #1807
Closed
1 task done

@web3-onboard/ledger is missing a dependency on @ethersproject/providers #1806

ghivert opened this issue Jul 5, 2023 · 2 comments · Fixed by #1807
Assignees
Labels
bug Something isn't working

Comments

@ghivert
Copy link

ghivert commented Jul 5, 2023

Current Behavior

Hi,

When using Yarn 3 with the latest release of Ledger onboard, an error pops up.

error - ../../.yarn/cache/@web3-onboard-ledger-npm-2.5.0-2c15715192-c2ded6b1d5.zip/node_modules/@web3-onboard/ledger/dist/v1.js:30:48
Module not found: Can't resolve '@ethersproject/providers'

It turns out that ledger is importing @ethersproject/providers, but it's not defined in the package.json.

Expected Behavior

Importing should not throw.

Steps To Reproduce

Init a project with Yarn 3, and init an app with ledger module.

What package is effected by this issue?

@web3-onboard/ledger

Is this a build or a runtime issue?

N/A

Package Version

2.5.0

Node Version

18.14.0

What browsers are you seeing the problem on?

Chrome

Relevant log output

No response

Anything else?

No response

Sanity Check

  • If this is a build issue, I have included my build config. If this is a runtime issue, I have included reproduction steps and/or a Minimal, Reproducible Example.
@Adamj1232
Copy link
Member

@ghivert thank you for opening this issue. We have a fix in PR here - #1807 and it will be available shortly

@Adamj1232
Copy link
Member

This fix is available with the latest alpha version of the ledger package as shown in the associated PR #1807
An official release for this package will be out shortly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants