Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Readme.md example code requires bitcore #30

Open
bochap opened this issue Jan 29, 2018 · 3 comments
Open

Readme.md example code requires bitcore #30

bochap opened this issue Jan 29, 2018 · 3 comments

Comments

@bochap
Copy link

bochap commented Jan 29, 2018

It looks like line var bitcore = require('bitcore'); in the Readme.md example is unused. Should that be removed. I can put in the PR

@bochap bochap closed this as completed Jan 30, 2018
@bochap bochap changed the title Readme.md example code has unused require Readme.md example code requires bitcore Jan 30, 2018
@bochap bochap reopened this Jan 30, 2018
@bochap
Copy link
Author

bochap commented Jan 30, 2018

Looking at this more should if be using bitcore-library instead of bitcore.

@carnesen
Copy link
Contributor

@seetD It seems to me that these days the "bitcore" package just exports the contents of the "bitcore-lib" package https://github.com/bitpay/bitcore/blob/95dc8b291089e2dec814d9a762df2ea341edef40/index.js So either way works fine. You're right though that "bitcore-lib" is probably "more right".

@bochap
Copy link
Author

bochap commented Jan 31, 2018

That's true. The reason I brought that back up was bitcore encompasses a lot more than bitcore-lib. So I thought that making it use bitcore-lib will be more modular if you are not using bitcore. I would be glad to create a PR for that if no one disagrees with that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants