Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

For Cycle 23 #818

Closed
wallclockbuilder opened this issue Apr 2, 2021 · 23 comments
Closed

For Cycle 23 #818

wallclockbuilder opened this issue Apr 2, 2021 · 23 comments
Assignees
@ripcurlx
Labels
parsed:valid https://bisq.wiki/Compensation#Ensure_your_request_is_valid team:dev https://bisq.wiki/Dev_Team was:not submitted Indicates that a compensation request was not submitted for DAO voting
Milestone
Cycle 23

Comments

@wallclockbuilder
Copy link

wallclockbuilder commented Apr 2, 2021 •
edited
Loading

Summary(Previous Cycle 22)

  • BSQ requested: 225.69
  • USD requested: 492
  • BSQ rate: 2.18 USD per BSQ

Contributions delivered

Title Team USD Link Notes
Changes "Verify result" to "Check signature" dev 15 5209 Code Review
Add step for signature creation for Arch Linux dev 349 5239 Code Review
Fix call rate metering interceptor bug dev 100 5250 Code Review
Fix opening of proposal links in DAO on Windows dev 21 5262 Code Review
Fix Set Password text button dev 5 5272 Code Review
Add NGN as a default currency dev 2 5293 Code Review
@ghost ghost added the parsed:invalid https://bisq.wiki/Compensation#Ensure_your_request_is_valid label Apr 2, 2021
@ghost
Copy link

ghost commented Apr 2, 2021

Info

Read BSQ amount from summary: 218.8073394
Read USD amount from summary: 477
Read BSQ rate from summary: 2.18
Parsed lineitem: {"team":"dev","amount":15}
Parsed lineitem: {"team":"dev","amount":349}
Parsed lineitem: {"team":"dev","amount":100}
Parsed lineitem: {"team":"dev","amount":21}
Parsed lineitem: {"team":"dev","amount":5}
Parsed lineitem: {"team":"dev","amount":2}

Errors

ERROR: Total USD does not match the sum of line items:

  • Summary total: 477.00 USD
  • Calculated total: 492.00 USD

@ghost ghost added team:dev https://bisq.wiki/Dev_Team parsed:valid https://bisq.wiki/Compensation#Ensure_your_request_is_valid parsed:invalid https://bisq.wiki/Compensation#Ensure_your_request_is_valid and removed parsed:invalid https://bisq.wiki/Compensation#Ensure_your_request_is_valid parsed:valid https://bisq.wiki/Compensation#Ensure_your_request_is_valid labels Apr 2, 2021
@ghost
Copy link

ghost commented Apr 3, 2021

Info

Read BSQ amount from summary: 406.6115702
Read USD amount from summary: 492
Read BSQ rate from summary: 1.21
Parsed lineitem: {"team":"dev","amount":15}
Parsed lineitem: {"team":"dev","amount":349}
Parsed lineitem: {"team":"dev","amount":100}
Parsed lineitem: {"team":"dev","amount":21}
Parsed lineitem: {"team":"dev","amount":5}
Parsed lineitem: {"team":"dev","amount":2}

Errors

Incorrect BSQ rate specified: 1.21, expected: 2.18
ERROR: Total BSQ does not match the sum of line items:

  • Summary total: 406.61 BSQ
  • Calculated total: 225.69 BSQ

@wallclockbuilder
Copy link
Author

It says for Cycle 22 in the title. Why is the bot still insisting on the cycle 23 rate?

@wallclockbuilder
Copy link
Author

I guess its ok. This issue had the same problem but was accepted anyway.
About time human overrules bot.

@MwithM
Copy link
Contributor

MwithM commented Apr 3, 2021 •
edited
Loading

Current DAO cycle, which its proposal phase will end in a week, is Cycle 23. Even if your job was done at Cycle 22, you should title your tasks as "For Cycle 23" and indicate if it's a past task.

@MwithM MwithM added this to the Cycle 23 milestone Apr 3, 2021
@wallclockbuilder wallclockbuilder changed the title For Cycle 22 For Cycle 23 Apr 3, 2021
@ghost
Copy link

ghost commented Apr 3, 2021

Info

Read BSQ amount from summary: 406.6115702
Read USD amount from summary: 492
Read BSQ rate from summary: 1.21
Parsed lineitem: {"team":"dev","amount":15}
Parsed lineitem: {"team":"dev","amount":349}
Parsed lineitem: {"team":"dev","amount":100}
Parsed lineitem: {"team":"dev","amount":21}
Parsed lineitem: {"team":"dev","amount":5}
Parsed lineitem: {"team":"dev","amount":2}

Errors

Incorrect BSQ rate specified: 1.21, expected: 2.18
ERROR: Total BSQ does not match the sum of line items:

  • Summary total: 406.61 BSQ
  • Calculated total: 225.69 BSQ

1 similar comment
@ghost
Copy link

ghost commented Apr 3, 2021

Info

Read BSQ amount from summary: 406.6115702
Read USD amount from summary: 492
Read BSQ rate from summary: 1.21
Parsed lineitem: {"team":"dev","amount":15}
Parsed lineitem: {"team":"dev","amount":349}
Parsed lineitem: {"team":"dev","amount":100}
Parsed lineitem: {"team":"dev","amount":21}
Parsed lineitem: {"team":"dev","amount":5}
Parsed lineitem: {"team":"dev","amount":2}

Errors

Incorrect BSQ rate specified: 1.21, expected: 2.18
ERROR: Total BSQ does not match the sum of line items:

  • Summary total: 406.61 BSQ
  • Calculated total: 225.69 BSQ

@wallclockbuilder
Copy link
Author

Updated.

@ghost
Copy link

ghost commented Apr 3, 2021

Info

Read BSQ amount from summary: 406.6115702
Read USD amount from summary: 492
Read BSQ rate from summary: 1.21
Parsed lineitem: {"team":"dev","amount":15}
Parsed lineitem: {"team":"dev","amount":349}
Parsed lineitem: {"team":"dev","amount":100}
Parsed lineitem: {"team":"dev","amount":21}
Parsed lineitem: {"team":"dev","amount":5}
Parsed lineitem: {"team":"dev","amount":2}

Errors

Incorrect BSQ rate specified: 1.21, expected: 2.18
ERROR: Total BSQ does not match the sum of line items:

  • Summary total: 406.61 BSQ
  • Calculated total: 225.69 BSQ

@ripcurlx
Copy link
Contributor

ripcurlx commented Apr 5, 2021

@wallclockbuilder Could you please resolve the issues pointed out by the bisq-bot so it can be reviewed? Thanks!

@wallclockbuilder
Copy link
Author

This is for previous cycle 22. The bot is insisting on cycle 23 rate.

I guess its ok. This issue had the same problem but was accepted anyway.

@MwithM
Copy link
Contributor

MwithM commented Apr 6, 2021

If all the tasks were for the previous cycle, it would be ok to use 1.21USD. Why didn't you submit this compensation request then?

@sqrrm
Copy link
Member

sqrrm commented Apr 6, 2021

The only reason to use an old exchange rate should be that the CR was held back for technical reasons like when there was too much BSQ requested and some contributors had to wait one cycle with their requests to avoid failing the vote due to hitting the max issuance limit.

Even in the case of a failed cycle I think it's right to use the current rate.

@MwithM
Copy link
Contributor

MwithM commented Apr 6, 2021

It's ok for me to do like this from now on.

@MwithM MwithM closed this as completed Apr 6, 2021
@MwithM
Copy link
Contributor

MwithM commented Apr 6, 2021

It's ok for me to do like this from now on.

@MwithM MwithM reopened this Apr 6, 2021
@wallclockbuilder
Copy link
Author

#523 submitted late and it was approved without any discretionary opinions. Is there any written policy concerning this?

@ghost
Copy link

ghost commented Apr 6, 2021

Info

Read BSQ amount from summary: 406.6115702
Read USD amount from summary: 492
Read BSQ rate from summary: 2.18
Parsed lineitem: {"team":"dev","amount":15}
Parsed lineitem: {"team":"dev","amount":349}
Parsed lineitem: {"team":"dev","amount":100}
Parsed lineitem: {"team":"dev","amount":21}
Parsed lineitem: {"team":"dev","amount":5}
Parsed lineitem: {"team":"dev","amount":2}

Errors

ERROR: Total BSQ does not match the sum of line items:

  • Summary total: 406.61 BSQ
  • Calculated total: 225.69 BSQ

@ghost
Copy link

ghost commented Apr 6, 2021

Info

Read BSQ amount from summary: 406.6115702
Read USD amount from summary: 492
Read BSQ rate from summary: 1.21
Parsed lineitem: {"team":"dev","amount":15}
Parsed lineitem: {"team":"dev","amount":349}
Parsed lineitem: {"team":"dev","amount":100}
Parsed lineitem: {"team":"dev","amount":21}
Parsed lineitem: {"team":"dev","amount":5}
Parsed lineitem: {"team":"dev","amount":2}

Errors

Incorrect BSQ rate specified: 1.21, expected: 2.18
ERROR: Total BSQ does not match the sum of line items:

  • Summary total: 406.61 BSQ
  • Calculated total: 225.69 BSQ

@ghost ghost added parsed:valid https://bisq.wiki/Compensation#Ensure_your_request_is_valid and removed parsed:invalid https://bisq.wiki/Compensation#Ensure_your_request_is_valid labels Apr 6, 2021
@wallclockbuilder
Copy link
Author

Updated rate to cycle 23 rate(2.18) as requested.

@ghost
Copy link

ghost commented Apr 6, 2021

New contributors often lack the domain knowledge to provide valuable code reviews.
I've not seen anyone else charge for code reviews other than the repository maintainers & I think that's how it should be.

Advice: accept constructive criticism & persevere. Improve your contributions.

@wallclockbuilder
Copy link
Author

wallclockbuilder commented Apr 8, 2021 •
edited
Loading

@MwithM. Noticed you moved this to "closed" earlier. Its ready for review now. Please move it to back to "in review".

@MwithM
Copy link
Contributor

MwithM commented Apr 9, 2021 •
edited
Loading

@wallclockbuilder I clicked the close issue button by mistake, and then reopened it afterwards. I did not realize that by doing that, the issue stayed as closed and did not go back to in review. Sorry for that, but I think that this is not the reason why the review did not get in time.
As for #819, I think it's better if the review for this tasks are finally reviewed. That can be done even after the issue is closed as not submitted. You can submit this for Cycle 24 as soon as it's reviewed.

Closed as not submitted.

@MwithM MwithM closed this as completed Apr 9, 2021
@MwithM MwithM added the was:not submitted Indicates that a compensation request was not submitted for DAO voting label Apr 9, 2021
@MwithM MwithM mentioned this issue Jun 14, 2021
Closed
@wallclockbuilder
Copy link
Author

@ripcurlx I'm ready to re-open this CR, what do I need to do? @MwithM

@wallclockbuilder wallclockbuilder mentioned this issue Aug 1, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ripcurlx ripcurlx

Labels
parsed:valid https://bisq.wiki/Compensation#Ensure_your_request_is_valid team:dev https://bisq.wiki/Dev_Team was:not submitted Indicates that a compensation request was not submitted for DAO voting
Projects
Compensation Request Board
Archived in project
Milestone
Cycle 23
Development

No branches or pull requests
4 participants
@ripcurlx @wallclockbuilder @sqrrm @MwithM