For November 2018 - February 2019

[oscarguindzberg]

Summary

Specify the total amount of BSQ you are requesting, and the BSQ address that amount should be paid to:

• BSQ requested: 40650
• BSQ address: B1LiYyuKpAZQHuyzRiFy8uBYNC71S8nEXQJ

Contributions delivered

Provide links to contributions you have delivered, the amount of BSQ you are requesting for each, and any comments that will help stakeholders understand its value.

I have focused on several bitcoinj related stuff.

These items describe my contributions from Nov 2018 to Feb 2019:

• "Feasibility for replacing Bitcoinj" research
  •  Feasibility for replacing Bitcoinj with Bitcoin Core SPV bisq#1062 (comment)
• "Review BIP 44 Implementation" code audit
  • Review BIP 44 Implementation bisq#1853 (comment)
• Write bugfix "When date of the seed is not specified use bisq 0.5 release date" (committed by Manfred)
  • bisq-network/bisq@717f5fb
• Several code cleanup PRs
  • Code cleanup - Code clean up bisq#2137
  • Remove Networks and AbstractBitcoinNetParams since they are not used - Remove Networks and AbstractBitcoinNetParams since they are not used bisq#2182
  • Fix getActiveKeyChain() typo - Fix getActiveKeyChain() typo bisq#2151
• "Bisq disconnected from local btc node" issue investigation
  • Bisq disconnected from local btc node bisq#1823 (comment)
  • Issue closed because a workaround was implemented, a new related issue should be created for the still unsolved problem.
• “Accepted offer failed to execute, went through anyway but never happened” issue investigation
  • Accepted offer failed to execute, went through anyway but never happened. bisq#2112 (comment)
• Fix bug "TX considered non-standard due to unknown version number 2"
  • Issue: TX considered non-standard due to unknown version number 2 bisq#1832
  • PR1: Basic support for version 2 transactions.  bisq#2127
  • PR2: Basic support for version 2 transactions.  bitcoinj#16
• jdk8 vs jdk 10
  • Found out bitcoinj has to be built using jdk8 and bisq has to be built using jdk10
  • Documented how to have both jdk8 and jdk10 on the same computer and wrote a script to switch between them.
  • Evaluate the risks of building with jdk8 and running with jdk10.
  • try to build bitcoinj using jdk10 and found lots of issues, documented the problems I had.
  • See details on jdk8 vs jdk 10 bitcoinj#17
• "Restore from seed" does not works on windows
  • Research
    • Found and documented the bug Can not restore from seed on windows bisq#2402
    • Part of the research is documented on jdk8 vs jdk10 issue jdk8 vs jdk 10 bitcoinj#17
    • Discuss on related (maybe duplicate) bug Unable to restore wallet from seed phrase. bisq#2323
    • Investigate "block store deletion problem on windows".
    • Write unit test that exposes the bug oscarguindzberg/bitcoinj@7bd0d36
    • Understand why WindowsMMapHack was necessary. Read:
      • https://github.com/bitcoinj/bitcoinj/blob/v0.14.7/core/src/main/java/org/bitcoinj/store/WindowsMMapHack.java
      • https://bugs.java.com/bugdatabase/view_bug.do?bug_id=4715154
      • http://www.mapdb.org/blog/mmap_files_alloc_and_jvm_crash/
      • https://bugs.java.com/bugdatabase/view_bug.do?bug_id=4724038
      • https://bugs.java.com/bugdatabase/view_bug.do?bug_id=6359560
    • Evaluate different approaches to solve the problem:
      • include sun.* classes
      • use LevelDBBlockStore
      • Remove usage of MappedByteBuffer in SPVBlockStore by using FileChannel or RandomAccessFile directly
  • Implement a solution that removes mmap usage
    • PR on bisq Use NonMMappedSPVBlockStore on windows. bisq#2403
    • PR on bitcoinj upstream [WIP] Remove mmap usage in SPVBlockStore bitcoinj/bitcoinj#1695
    • Test performance of the PR: SPVBlockStoreTest.performanceTest() fails on a mac, on a windows box on aws and travis-ci (Had to fix bitcoinj upstream to print test log on travis-ci Make travis to print failed tests on the console bitcoinj/bitcoinj#1699)
  • Implement alternative solution with SPVBlockStore.clear()
    • PR on bisq Replace NonMMappedSPVBlockStore by ClearableSPVBlockStore bisq#2438
    • PR on bitcoinj upstream Clear the blockchain file (as opposed to delete it) in preparation for restore bitcoinj/bitcoinj#1702
  • Test restore from seed on wallet-template bitcoinj project
    • Create issue upstream because it fails Wallet template restore from seed fails bitcoinj/bitcoinj#1704
• Rebuild commit history of bisq’s bitcoinj
  • "Merge" has been used instead of "rebase" for years to add code and to bring new changes from bitcoinj upstream. In that context some tasks are very hard and risky to do: Understanding what (and why) has changed compared to the original bitcoinj, deciding whether a change makes sense or not, using "git blame", incorporating changes from upstream, doing more changes to the code.
  • I rebuilt the commit history from scratch. Now every commit makes sense on its own, has a descriptive commit message and a link to the original commit.
  • New commit history: https://github.com/oscarguindzberg/bitcoinj/commits/bisq_0.14.4.1-rebase2
  • Old commit history: https://github.com/bisq-network/bitcoinj/commits/bisq_0.14.4.1
• Rebase bisq’s bitcoinj from v0.14.7 upstream
  • See https://github.com/oscarguindzberg/bitcoinj/tree/bisq_0.14.7-original
  • Run unit tests and make sure no more test fail compared to the ones that already fail on bisq’s bitcoinj 0.14.4.1 branch
  • Review upstream bitcoinj commits from v0.14.4 to v0.14.7
    • Remove bloq’s dns seed oscarguindzberg/bitcoinj@b3b3b64
• Fix failing tests on bisq's bitcoinj branch
  • Failing tests bitcoinj#19
• Update harcoded seed nodes
  • bisq-network/bitcoinj@b8541e1
• Prevent DoS attacks to bitcoinj.
  • bisq-network/bitcoinj@a4abdb6
  • bisq-network/bitcoinj@66c5bd4
• Code review of bisq's bitcoinj
  • Review the changes done by bisq to bitcoinj (tor/hidden services, fee calculation and connection handling changes still have to be reviewed)
  • Implement changes on https://github.com/bisq-network/bitcoinj/tree/bisq_0.14.7
  • See details in Bisq's bitcoinj general changes audit bitcoinj#20
• Use bitcoinj 0.14.7 in bisq
  • Use bitcoinj 0.14.7 bisq#2478
• Review “Clone transaction before adding to wallet” PR
  • Clone transaction before adding to wallet bitcoinj#18
• Review “Transaction can serialize and deserialize according to Segwit”
  • Transaction can serialize and deserialize according to Segwit bitcoinj#13 (comment)
• Bisq dev session presentation: bitcoinj
• Remove "pricenode" direct dependency on "assets"
  • Remove "pricenode" direct dependency on "assets" bisq#2197
• Be able to upgrade bitcoinj without upgrading libdohj
  • Be able to upgrade bitcoinj without upgrading libdohj bisq#2198
• Remove libdohj dependency from bisq
  • Remove libdohj dependency bisq#2368
  • Revert Dash specific change on bitcoinj: oscarguindzberg/bitcoinj@5b35c84

Contributions in progress

Provide links to work you're involved with that is still in progress. This section is optional, and is for your own benefit in keeping track of what you're doing and keeping other contributors up to date with the same.

• Investigate moving to bitcoinj upstream master
  • https://groups.google.com/forum/#!topic/bitcoinj/M05pt8Hwnw0
  • https://groups.google.com/forum/#!topic/bitcoinj/qjxgcpKak3s
  • Participate in Support for Bitcoin Bech32 SegWit addresses bisq#1139
  • https://groups.google.com/forum/#!topic/bitcoinj/kE6hO3Cj8-Q
  • Review bitcoinj master source code
  • Review Full support for native segwit. bitcoinj/bitcoinj#1563 (see my comments)
  • Send email asking for 0.15 release notes - https://groups.google.com/forum/#!topic/bitcoinj/kE6hO3Cj8-Q
  • Investigate segwit bip144 support in bitcoinj https://groups.google.com/forum/#!topic/bitcoinj/qjxgcpKak3s

Roles performed

Provide links to your monthly report on any roles you are responsible for.

[ManfredKarrer]

@oscarguindzberg You can find the BSQ address in the mainnet Bisq app when you click cmd+d then the DAO menu item becomes visible where you find a single screen with a BSQ address.

[ManfredKarrer]

Please remove the WIP once the request is final.

[ManfredKarrer]

You can add merged code to completed work. We changed policy a while back to that merged PRs are considered delivered work.

[ripcurlx]

@oscarguindzberg I didn't transfer your compensation request for voting because it was marked with [WIP]. Feel free to submit it for next month's voting cycle.

As the title was changed I added it to this month's (February 2019) voting round.

[ManfredKarrer]

Thanks @oscarguindzberg for the detailed overview!

[ManfredKarrer]

Regaring bisq-network/bisq#2478 : I did not had time today to review and test it but it will be done soon. So lets make an exception here and consider it as merged ;-) (there is no doubt that it gets merged).

[m52go]

Hello @oscarguindzberg would you mind making a corresponding compensation request in the testnet Bisq DAO, if you haven't already? Would really help us with testing this round.

The proposal phase for this round ends sometime tonight.

https://docs.bisq.network/getting-started-dao.html

[ManfredKarrer]

@ripcurlx Seems you added it still to the spreadsheet. Could you edit/strike your above comment?

[ripcurlx]

@ripcurlx Seems you added it still to the spreadsheet. Could you edit/strike your above comment?

Done.

[ripcurlx]

Closing as complete, see #222 (comment).